feat: Release v28 #1473
Open
feat: Release v28 #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cmul and ecpairing
Co-authored-by: Vlad Bochok <[email protected]>
Merge release-v27 into ec precompiles
Mmzk remerge v27
chore: Merge V27 in dev
Co-authored-by: Vladislav Volosnikov <[email protected]>
Merging new changes from v28
feat: Add ec precompiles in V28
Fixed hashes, calculated with correct Foundry version. Added check of Foundry version to recompute_hashes.sh.
… add new commands in system-contracts
…ase-v27 Sync draft-v28 with release-v27
chore: Merge main in dev
Co-authored-by: Raid Ateir <[email protected]> Co-authored-by: Raid5594 <[email protected]>
Co-authored-by: koloz <[email protected]>
…ith-upgrades Add test for the default upgrade with gateway
feat: add fast building
koloz193
requested review from
Deniallugo,
vladbochok and
StanislavBreadless
as code owners
Co-authored-by: Raid Ateir <[email protected]> Co-authored-by: Raid5594 <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
73
to
104
| run: yarn | ||
|
|
||
| - name: Run lint | ||
| run: yarn lint:check | ||
|
|
||
| # FIXME: recover when used multivm is updated | ||
| # test-bootloader: | ||
| # needs: [build, lint] | ||
| # runs-on: ubuntu-latest | ||
|
|
||
| # steps: | ||
| # - name: Checkout the repository | ||
| # uses: actions/checkout@v4 | ||
|
|
||
| # - name: Install rust | ||
| # uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| # with: | ||
| # toolchain: nightly-2024-08-01 | ||
|
|
||
| # - name: Restore artifacts cache | ||
| # uses: actions/cache/restore@v3 | ||
| # with: | ||
| # fail-on-cache-miss: true | ||
| # key: artifacts-system-${{ github.sha }} | ||
| # path: | | ||
| # system-contracts/zkout | ||
| # system-contracts/cache-forge | ||
| # system-contracts/bootloader/build | ||
| # system-contracts/artifacts-zk | ||
| # system-contracts/cache-zk | ||
| # system-contracts/typechain | ||
| # system-contracts/contracts-preprocessed | ||
|
|
||
| # - name: Run bootloader tests | ||
| # run: | | ||
| # cd system-contracts/bootloader/test_infra | ||
| # cargo run | ||
| test-bootloader: | ||
| needs: [build, lint] | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout the repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install rust | ||
| uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| toolchain: nightly-2024-08-01 | ||
|
|
||
| - name: Restore artifacts cache | ||
| uses: actions/cache/restore@v3 | ||
| with: | ||
| fail-on-cache-miss: true | ||
| key: artifacts-system-${{ github.sha }} | ||
| path: | | ||
| system-contracts/zkout | ||
| system-contracts/cache-forge | ||
| system-contracts/bootloader/build | ||
| system-contracts/artifacts-zk | ||
| system-contracts/cache-zk | ||
| system-contracts/typechain | ||
| system-contracts/contracts-preprocessed | ||
| l1-contracts/zkout |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 11 days ago
To fix the issue, we will add a permissions key at the workflow level to define the least privileges required for all jobs. Based on the actions used in the workflow:
contents: readis sufficient for most steps, such asactions/checkoutandactions/cache.- No write permissions are required since the workflow does not modify repository contents or interact with features like issues or pull requests.
The permissions key will be added at the top level of the workflow to apply to all jobs.
Suggested changeset
1
.github/workflows/system-contracts-ci.yaml
| @@ -5,2 +5,5 @@ | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Contract changes required for protocol version v28. Some key highlights are:
ecadd,ecmul,ecpairing, andmodexpWhy ❔
Moving from solidity based implementations to precompiles boosts the performance of these operations when run in our zkvm.
Checklist