Zksync os with kl medium interop by kelemeno · Pull Request #1949 · matter-labs/era-contracts

kelemeno · 2026-01-06T23:28:00Z

What ❔

Why ❔

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.

…s into kl/17-10-25/merge-draft

Kl/17 10 25/merge draft

…contracts into kl/14-10-25/remove-timeframe-assumption

Signed-off-by: Danil <deniallugo@gmail.com> # Conflicts: # AllContractsHashes.json # l1-contracts/deploy-scripts/DeployCTM.s.sol # l1-contracts/deploy-scripts/RegisterZKChain.s.sol # l1-contracts/deploy-scripts/upgrade/DefaultEcosystemUpgrade.s.sol # l1-contracts/deploy-scripts/upgrade/EcosystemUpgrade_v26_1.s.sol # l1-contracts/deploy-scripts/upgrade/EcosystemUpgrade_v28.s.sol

Signed-off-by: Danil <deniallugo@gmail.com> # Conflicts: # l1-contracts/deploy-scripts/DeployL2Contracts.sol # l1-contracts/deploy-scripts/gateway/GatewayCTMFromL1.s.sol # l1-contracts/deploy-scripts/gateway/GatewayGovernanceUtils.s.sol

Signed-off-by: Danil <deniallugo@gmail.com>

…dium-interop

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1ce9d4c35

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-06T23:32:14Z

l1-contracts/contracts/core/bridgehub/L2InteropRootStorage.sol

+    /// @dev FIXME: for the demo purposes, remove onlyCallFromBootloader modifier
+    function addInteropRoot(uint256 chainId, uint256 blockOrBatchNumber, bytes32[] calldata sides) external {
+        // In the current code sides should only contain the Interop Root itself, as mentioned above.


Restrict interop root writes to trusted caller

Because addInteropRoot is declared external with no access control, any address can set the interop root for an arbitrary (chainId, blockOrBatchNumber) once. L2MessageVerification later treats L2_INTEROP_ROOT_STORAGE.interopRoots(...) as the source of truth for message inclusion, so an attacker who pre-fills a root can craft proofs that verify forged bundles/messages on L2. This is exploitable whenever a malicious party can submit addInteropRoot before the legitimate publisher for that pair.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-06T23:32:14Z

l1-contracts/contracts/interop/InteropCenter.sol

+            // FIXME: does not burn, just sends to a a bad address.
            // slither-disable-next-line arbitrary-send-eth
-            L2_BASE_TOKEN_SYSTEM_CONTRACT.burnMsgValue{value: _totalBurnedCallsValue}();
+            address(0xdeadbeef).call{value: _totalBurnedCallsValue}("");


Burn msg.value instead of transferring to 0xdeadbeef

In _ensureCorrectTotalValue, the burn path for same-base-token interop bundles now transfers _totalBurnedCallsValue to 0xdeadbeef instead of calling L2_BASE_TOKEN_SYSTEM_CONTRACT.burnMsgValue. That does not update the base-token system contract’s accounting, so bundles that are supposed to burn value will leave the L2 supply/state out of sync with L1 accounting. This only affects bundles where destinationChainBaseTokenAssetId == thisChainBaseTokenAssetId and _totalBurnedCallsValue > 0, but in that case reconciliation/withdrawals can break because no actual burn is recorded.

Useful? React with 👍 / 👎.

kelemeno and others added 30 commits October 17, 2025 10:52

Merge branch 'draft-v30' of ssh://github.com/matter-labs/era-contract…

1079469

…s into kl/17-10-25/merge-draft

imports

d86014c

getting to build

43496f7

lint

7cdf58b

Merge pull request #1733 from matter-labs/kl/17-10-25/merge-draft

899b659

Kl/17 10 25/merge draft

add back paused deposits to make it mergeable

39c0970

avoid AvoidStackTooDeep struct

f631ebd

fix build

fd84f92

move L1 only function to L1ChainAH from ChainAHBase

6596331

add new bridgeConfirmTransferResult

dd0e8e7

more fixes

03e2eda

linting

6f2add9

lint

1a36a03

remove dead code

f9a3f8d

proper capitalisation

4b54cc2

Merge branch 'kl/medium-interop' of ssh://github.com/matter-labs/era-…

7eb6448

…contracts into kl/14-10-25/remove-timeframe-assumption

whole refactoring

a1b2090

Signed-off-by: Danil <deniallugo@gmail.com>

Fix Inspector

5413ee1

Signed-off-by: Danil <deniallugo@gmail.com>

lint

4ae807f

Signed-off-by: Danil <deniallugo@gmail.com>

fix

f4faec0

Signed-off-by: Danil <deniallugo@gmail.com>

Add deploy ctm script

4998c59

Signed-off-by: Danil <deniallugo@gmail.com>

fix verifier

525e8d4

Signed-off-by: Danil <deniallugo@gmail.com>

remove old contracts

5d0230f

Signed-off-by: Danil <deniallugo@gmail.com>

Fix register

73b5800

Signed-off-by: Danil <deniallugo@gmail.com>

Fix create2 contracts

f19fa4e

Signed-off-by: Danil <deniallugo@gmail.com>

Move deployed adddresses to another script

9871c24

Signed-off-by: Danil <deniallugo@gmail.com>

fix tests

23aa9b5

Fix tests

b96847e

Signed-off-by: Danil <deniallugo@gmail.com>

Deniallugo and others added 25 commits December 19, 2025 18:58

Fix constants

132ae4b

Signed-off-by: Danil <deniallugo@gmail.com>

Found problematic upgrade part

0137245

Signed-off-by: Danil <deniallugo@gmail.com>

hacky l2 interop

8c01fbc

Fix force deployments

96a7106

Signed-off-by: Danil <deniallugo@gmail.com>

Return back SYSTEM_CONTRACT_PROXY_ADMIN_ADDRESS

2b1e41d

Signed-off-by: Danil <deniallugo@gmail.com>

Ignore upgrade only for genesis

04a185b

Signed-off-by: Danil <deniallugo@gmail.com>

Update addresses

fcbbec6

Signed-off-by: Danil <deniallugo@gmail.com>

An attempt to fix l2 asset tracker test

dd42776

Signed-off-by: Danil <deniallugo@gmail.com>

Fix wrong commitment

ebfa490

Signed-off-by: Danil <deniallugo@gmail.com>

Fix l1 rollup field for zksync os blobs

6adc8dd

Signed-off-by: Danil <deniallugo@gmail.com>

upd files

04df19d

remove additional checks

30fd113

Fix l1 rollup field for zksync os blobs

2f0f57a

Signed-off-by: Danil <deniallugo@gmail.com>

Fix the place for blobs_zksync_os_l1_da_validator_addr

1c4d1eb

Signed-off-by: Danil <deniallugo@gmail.com>

Fix test for L2AssetTracker.t.sol

8eb48fe

Signed-off-by: Danil <deniallugo@gmail.com>

Calculate empty message root

eb7f45a

Signed-off-by: Danil <deniallugo@gmail.com>

Add comments and fix review issues

5c464ff

Signed-off-by: Danil <deniallugo@gmail.com>

Transfer ownership

f9fd0b7

Signed-off-by: Danil <deniallugo@gmail.com>

Make compare string private

f7b280c

Signed-off-by: Danil <deniallugo@gmail.com>

Fix verifier owner

03d89a6

Signed-off-by: Danil <deniallugo@gmail.com>

fix lints

79066df

Signed-off-by: Danil <deniallugo@gmail.com>

fix typo

504d2b0

Signed-off-by: Danil <deniallugo@gmail.com>

Refactor

4bbcecc

Signed-off-by: Danil <deniallugo@gmail.com>

Merge branch 'deniallugo-zksync-os-genesis' into zksync-os-with-kl-me…

00dd8fb

…dium-interop

Merge branch 'draft-v31' into zksync-os-with-kl-medium-interop

e1ce9d4

kelemeno requested review from Deniallugo, StanislavBreadless and vladbochok as code owners January 6, 2026 23:28

chatgpt-codex-connector bot reviewed Jan 6, 2026

View reviewed changes

small issues

1ce5900

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zksync os with kl medium interop#1949

Zksync os with kl medium interop#1949
kelemeno wants to merge 1042 commits intodraft-v31from
zksync-os-with-kl-medium-interop

kelemeno commented Jan 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Jan 6, 2026

Uh oh!

chatgpt-codex-connector bot Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

kelemeno commented Jan 6, 2026

What ❔

Why ❔

Checklist

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants