Porting splitting GW CTM deployer into the zksync-os compatible branch#1974
Conversation
…b/split-gw-ctm-deployer-with-zksync-os
StanislavBreadless
requested review from
Deniallugo and
vladbochok
as code owners
StanislavBreadless
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e39b707942
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| try zkChain.getChainTypeManager() returns (address result) { | ||
| chainCTM = result; | ||
| } catch { | ||
| continue; |
There was a problem hiding this comment.
l1-contracts/AGENTS.md explicitly forbids try-catch, and this new try zkChain.getChainTypeManager() path swallows reverts and silently skips a chain when the call fails (e.g., misconfigured or uninitialized chain), returning address(0) later. That hides real errors in deploy/introspection workflows that are supposed to fail fast and makes it easy to ship with incorrect address resolution.
Useful? React with 👍 / 👎.
| // Call getName() on the facet | ||
| (bool success, bytes memory data) = facetAddr.staticcall(abi.encodeWithSignature("getName()")); |
There was a problem hiding this comment.
l1-contracts/AGENTS.md also forbids staticcall; the new facet-name probe uses staticcall and masks failures by just skipping facets when the call fails, which can leave adminFacet/mailboxFacet/etc. unset without surfacing an error. This violates the repo’s fail-fast rule and can mislead scripts that rely on complete facet discovery.
Useful? React with 👍 / 👎.
|
lints dont pass because of zksync os related changes. I will merge the PR to only include the correct hashes |
StanislavBreadless
merged commit 138d2a0
into
draft-v31-with-zksync-os
StanislavBreadless
deleted the
sb/split-gw-ctm-deployer-with-zksync-os
branch
1 participant
What ❔
ports draft-v31 changes + the ones inside #1964
Why ❔
Checklist