-
Notifications
You must be signed in to change notification settings - Fork 401
chore: add zkstack-out CI check #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71bc4983d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This reverts commit 71bc498.
|
Coverage after merging sma/add-zkstack-out-ci-check into draft-v31 will be
Coverage Report</ |
## What ❔ This is a sister PR to matter-labs/era-contracts#1977 <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Merged latest draft-v31 changes including: - foundry fixes (matter-labs#1981) - ZKsyncOSDualVerifier (matter-labs#1980) - zksync-foundry v0.1.5 (matter-labs#1959) - zkstack-out CI check (matter-labs#1977) Resolved conflicts in L2 integration tests by keeping both: - vm.etch-based deployL2Weth() and setUpInner() overrides - New getChainCreationParamsConfig() override
What ❔
Adds a CI check to ensure that
l1-contracts/zkstack-outis kept up to date, plus some other cosmetic fixesThis is a sister PR to matter-labs/zksync-era#4616
Why ❔
Checklist