Skip to content

chore: add zkstack-out CI check #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkzoomer merged 6 commits into from
Jan 20, 2026
Merged

chore: add zkstack-out CI check #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3271a80
add zkstack-out CI check
zkzoomer Jan 19, 2026
71bc498
cheeky test
zkzoomer Jan 19, 2026
d9655b1
Merge remote-tracking branch 'origin/draft-v31' into sma/add-zkstack-…
zkzoomer Jan 19, 2026
7699c8d
Revert "cheeky test"
zkzoomer Jan 19, 2026
dc75da4
fixes
zkzoomer Jan 19, 2026
9e19de6
fix selectors
zkzoomer Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/l1-contracts-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,17 @@ jobs:
- name: Build l1 contracts
working-directory: l1-contracts
run: |
rm -rf zkstack-out
yarn build:foundry

# Fail if regenerated zkstack-out differs from what was committed
if [ -n "$(git status --porcelain -- zkstack-out)" ]; then
echo "::error::l1-contracts/zkstack-out is out of date. Run 'cd l1-contracts && yarn build:foundry' and commit the changes."
git --no-pager status --porcelain -- zkstack-out
git --no-pager diff -- zkstack-out || true
exit 1
fi

- name: Build l2 contracts
working-directory: l2-contracts
run: |
Expand Down
9 changes: 9 additions & 0 deletions l1-contracts/contracts/script-interfaces/IGatewayVotePreparation.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.21;

/// @title IGatewayVotePreparation
/// @notice Interface for GatewayVotePreparation.s.sol script
/// @dev This interface ensures selector visibility for GatewayVotePreparation functions
interface IGatewayVotePreparation {
function run(address bridgehubProxy, uint256 ctmRepresentativeChainId) external;
}
38 changes: 0 additions & 38 deletions l1-contracts/contracts/script-interfaces/IValidatorTimelockForZKStack.sol
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions l1-contracts/contracts/state-transition/IChainTypeManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ interface IChainTypeManager {

function validatorTimelock() external view returns (address);

function validatorTimelockPostV29() external view returns (address);

function initialize(ChainTypeManagerInitializeData calldata _initializeData) external;

function setLegacyValidatorTimelock(address _validatorTimelock) external;
Expand Down
7 changes: 2 additions & 5 deletions l1-contracts/scripts/copy-to-zkstack-out.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,16 @@ const REQUIRED_CONTRACTS = [
"L1Bridgehub.sol",
"MessageRootBase.sol",
"IZKChain.sol",
"IChainTypeManagerForZKStack.sol",
"IValidatorTimelockForZKStack.sol",
"IValidatorTimelock.sol",
"IChainAssetHandler.sol",
"IChainTypeManager.sol",
"IAdmin.sol",
"IChainAdminOwnable.sol",
"IRegisterZKChain.sol",
"IDeployL2Contracts.sol",
"DeployPaymaster.s.sol",
"IDeployPaymaster.sol",
"GatewayVotePreparation.s.sol",
"IGatewayVotePreparation.sol",
"AdminFunctions.s.sol",
"EnableEvmEmulator.s.sol",
"DeployGatewayTransactionFilterer.s.sol",
"IAdminFunctions.sol",
"IEnableEvmEmulator.sol",
Expand Down
30 changes: 10 additions & 20 deletions l1-contracts/selectors
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4562,6 +4562,8 @@ IChainTypeManager
|----------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------|
| Function | validatorTimelock() | 0xe66c8c44 |
|----------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------|
| Function | validatorTimelockPostV29() | 0xef9955bc |
|----------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------|
| Event | GenesisUpgrade(address,(uint256,uint256,uint256,uint256,uint256,uint256,uint256,uint256,uint256,uint256,uint256[4],bytes,bytes,uint256[],bytes,bytes),uint256) | 0x778b7f95aad9610955002f243aabbbf9546bb6e792f7b3b89dab86b4f210e30f |
|----------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------|
| Event | NewAdmin(address,address) | 0xf9ffabca9c8276e99321725bcb43fb076a6c66a54b7f21c4e8146d8519b417dc |
Expand Down Expand Up @@ -4841,6 +4843,14 @@ IGatewayUtils
| Function | finishMigrateChainToGateway(address,bytes,uint256,uint256,bytes32,uint256,uint256,uint16,bytes32[],uint8) | 0x59067261 |
╰----------+-----------------------------------------------------------------------------------------------------------+------------╯

IGatewayVotePreparation

╭----------+----------------------+------------╮
| Type | Signature | Selector |
+==============================================+
| Function | run(address,uint256) | 0x381fd190 |
╰----------+----------------------+------------╯

IGetters

╭----------+-------------------------------------------+------------╮
Expand Down Expand Up @@ -6319,26 +6329,6 @@ IValidatorTimelock
| Event | ReportCommittedBatchRangeZKsyncOS(uint64,uint64,uint64) | 0xa2ac105688fc09c2584d6b2e79dd0fc14e6003a20c62ac45aa858e8ed12bb7bb |
╰----------+------------------------------------------------------------------+--------------------------------------------------------------------╯

IValidatorTimelockForZKStack

╭----------+--------------------------------------------+------------╮
| Type | Signature | Selector |
+====================================================================+
| Function | COMMITTER_ROLE() | 0x1a7c3f73 |
|----------+--------------------------------------------+------------|
| Function | EXECUTOR_ROLE() | 0x07bd0265 |
|----------+--------------------------------------------+------------|
| Function | PRECOMMITTER_ROLE() | 0xa86d67c5 |
|----------+--------------------------------------------+------------|
| Function | PROVER_ROLE() | 0xdc9a4ef6 |
|----------+--------------------------------------------+------------|
| Function | hasRole(uint256,bytes32,address) | 0x119345aa |
|----------+--------------------------------------------+------------|
| Function | hasRoleForChainId(uint256,bytes32,address) | 0x8e80aaf6 |
|----------+--------------------------------------------+------------|
| Function | validators(uint256,address) | 0x91b19874 |
╰----------+--------------------------------------------+------------╯

IVerifier

╭----------+-----------------------------+------------╮
Expand Down
55 changes: 0 additions & 55 deletions l1-contracts/zkstack-out/DeployPaymaster.s.sol/DeployPaymaster.json
View file
Open in desktop

This file was deleted.

58 changes: 0 additions & 58 deletions l1-contracts/zkstack-out/EnableEvmEmulator.s.sol/EnableEvmEmulator.json
View file
Open in desktop

This file was deleted.

Loading
Loading