chore: update verifier contracts with new keys#2028
chore: update verifier contracts with new keys#2028zksync-admin-bot2 wants to merge 1 commit intomainfrom
Conversation
zksync-admin-bot2
requested review from
StanislavBreadless,
kelemeno and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebf3486d24
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| mstore(VK_GATE_SETUP_0_X_SLOT, 0x04534919c97c20c9f381efb25a676a165469b6401e20f80377d54572575513f9) | ||
| mstore(VK_GATE_SETUP_0_Y_SLOT, 0x291dc20070871f0a781bc924f604958ed8b8408b29990408f9a96a2bb21f286e) |
There was a problem hiding this comment.
Changing VK_GATE_SETUP_0_* and VK_GATE_SETUP_6_* here alters the memory block hashed by verificationKeyHash() (it hashes from VK_GATE_SETUP_0_X_SLOT through VK_RECURSIVE_FLAG_SLOT), so the PLONK verifier hash returned at runtime will change. The commit does not update the hardcoded expected hash (0x6625fa...) in testVerificationKeyHash assertions under l1-contracts/test/foundry/l1/unit/concrete/Verifier/PlonkVerifier.t.sol and the L2 verifier tests, which will make those checks fail once this change lands.
Useful? React with 👍 / 👎.
1 participant
Update verifier contracts with new keys