Skip to content

Alm protocol cli v0.31.0 tjg experiments#2039

Closed
tomg10 wants to merge 16 commits intodraft-v31from
alm-protocol-cli-v0.31.0-tjg-experiments
Closed

Alm protocol cli v0.31.0 tjg experiments#2039
tomg10 wants to merge 16 commits intodraft-v31from
alm-protocol-cli-v0.31.0-tjg-experiments

Conversation

@tomg10
Copy link

@tomg10 tomg10 commented Feb 17, 2026

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@tomg10 tomg10 changed the base branch from main to draft-v31 February 17, 2026 21:38
@tomg10 tomg10 marked this pull request as draft February 17, 2026 21:38
@tomg10 tomg10 closed this Feb 17, 2026
@chatgpt-codex-connector
Copy link

💡 Codex Review

) public payable virtual override onlyL2InteropCenter {
_bridgehubDepositBaseToken(_chainId, _assetId, _originalCaller, _amount);

P1 Badge Enforce pause checks on base-token interop deposits

bridgehubDepositBaseToken can still execute while the router is paused because it calls _bridgehubDepositBaseToken directly and lacks whenNotPaused, unlike the non-base path (_bridgehubDeposit) which is pause-gated. In an incident-response pause, L2_INTEROP_CENTER can therefore keep processing base-token deposits, defeating the emergency stop for that asset class.


L2_LEGACY_SHARED_BRIDGE = _legacySharedBridge;
require(address(_l1AssetRouter) != address(0), EmptyAddress());
L1_CHAIN_ID = _l1ChainId;
L1_ASSET_ROUTER = _l1AssetRouter;
BASE_TOKEN_ASSET_ID = _baseTokenAssetId;

P2 Badge Set BRIDGE_HUB during updateL2 upgrades

updateL2 is the non-genesis upgrade path for L2AssetRouter, but it never initializes BRIDGE_HUB. Since the previous implementation stored bridgehub as an immutable (no storage slot), upgraded proxies leave this new storage field at zero, so BRIDGE_HUB() returns address(0) after upgrade and breaks backward-compatible consumers expecting the bridgehub address.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants