feat: add sl chain id to batch output hash#2048
Closed
perekopskiy wants to merge 1 commit intodraft-v31-with-zksync-osfrom
Closed
feat: add sl chain id to batch output hash#2048perekopskiy wants to merge 1 commit intodraft-v31-with-zksync-osfrom
perekopskiy wants to merge 1 commit intodraft-v31-with-zksync-osfrom
Conversation
perekopskiy
requested review from
StanislavBreadless and
vladbochok
as code owners
AntonD3
reviewed
Feb 23, 2026
| _expectedSystemContractUpgradeTxHash, | ||
| _newBatch.dependencyRootsRollingHash | ||
| _newBatch.dependencyRootsRollingHash, | ||
| block.chainid |
Contributor
There was a problem hiding this comment.
Not very important, but do you think it makes sense to pass it separately in the batch commit info, and make sure that it equals block.chainId? This way, if the operator accidentally uses the wrong chain id, it will fail explicitly with a clear error, also it will be consistent with how we process other fields.
Contributor
Author
|
Closing in favor of #2049, which is going to cherry-picked to the target branch after it's merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Adds sl chain id to batch output hash to match zksync-os batch output hash calculation
Why ❔
Checklist