Merged
Conversation
zkzoomer
requested review from
Deniallugo,
StanislavBreadless and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f53661a178
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| abi.encodeCall( | ||
| L1NativeTokenVault.initialize, | ||
| (config.deployerAddress, coreAddresses.bridges.bridgedTokenBeacon) | ||
| (coreAddresses.shared.governance, coreAddresses.bridges.bridgedTokenBeacon) |
There was a problem hiding this comment.
Changing L1NativeTokenVault.initialize to use coreAddresses.shared.governance makes the proxy owner a governance contract immediately, but the deployment flow still performs owner-only calls from getDeployerAddress() (e.g. setAssetTracker and later transferOwnership in DeployL1CoreContracts.updateSharedBridge/updateOwners). In a fresh deployment this causes those calls to revert with unauthorized ownership checks, so the L1 core deployment script can no longer complete.
Useful? React with 👍 / 👎.
| mstore(VK_GATE_SETUP_6_Y_SLOT, 0x060b7c13eb18593c67a6cd94f24b8403dd97157a3f4096d1ce3c1e9b2fb53c12) | ||
| mstore(VK_GATE_SETUP_7_X_SLOT, 0x1affeacdceb1b6f018bbb6762bb5aebcd54c3e24801ce01d06146d1bf0938b2c) | ||
| mstore(VK_GATE_SETUP_7_Y_SLOT, 0x19a277dd9eaac40538f3177e3390ec21d097f88afb04158dd59e963a327fe9da) | ||
| mstore(VK_GATE_SETUP_0_X_SLOT, 0x007ab3b6eb38bcb3d387e923a00c9a0e76181545797111e9920869e95413f8b2) |
There was a problem hiding this comment.
This updates ZKsyncOSVerifierPlonk._loadVerificationKey to Era scheduler constants (0x007ab3... etc.), and the same commit also rewrites ZKsyncOSVerifierFflonk to Era c0, while the ZKsyncOS key material (tools/verifier-gen/data/ZKsyncOS_*_scheduler_key.json) still corresponds to the previous ZKsyncOS constants (0x1106b2... / 0x183ae3...). If deployed as-is, ZKsyncOS chains will validate proofs against the wrong VK and reject otherwise valid batches.
Useful? React with 👍 / 👎.
kelemeno
approved these changes
Feb 26, 2026
zkzoomer
force-pushed
the
sma/merge-main-draft-v31
branch
from
1e103fe to
de219d4
Compare
Contributor
|
Coverage after merging sma/merge-main-draft-v31 into draft-v31 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist