fix: use normal getter for chain tree#2059
fix: use normal getter for chain tree#2059perekopskiy wants to merge 1 commit intodraft-v31-zksync-osfrom
Conversation
perekopskiy
requested review from
StanislavBreadless and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c0dd2d7ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return sharedTree.merklePath(index); | ||
| } | ||
|
|
||
| function getChainTree(uint256 chainId) external view returns (DynamicIncrementalMerkle.Bytes32PushTree memory) { |
There was a problem hiding this comment.
Changing chainTree from a public mapping to an internal mapping and introducing getChainTree(uint256) changes the exported selector set (chainTree(uint256) is removed, getChainTree(uint256) is added), but this commit does not update l1-contracts/selectors; in this repo, .github/workflows/l1-contracts-ci.yaml runs yarn l1 selectors --check (check-selectors job), and scripts/selectors.ts fails on any exact mismatch, so this change will trip CI and also breaks callers still using the old chainTree(uint256) selector.
Useful? React with 👍 / 👎.
2 participants
What ❔
use normal getter for chain tree
Why ❔
auto-generated getter doesn't return struct's arrays
Checklist