This repository was archived by the owner on Mar 25, 2024. It is now read-only.
feat: preparing system contracts for shared bridge#86
Open
feat: preparing system contracts for shared bridge#86
Conversation
…cts into kl-factory
…ts into kl-factory
Sync dev with main
* System contracts test preprocessing mode * Mock dependencies, event writer asm contract test, refactoring * lint fix * Small refactoring * Change approach to use the test node * Add docs, comments * lint readme * Fix hashes * Regenerate yarn.lock to fix lints * lint:fix * Fix lints * Restore lost tests * Fix lints * Restore yarn.lock from dev * Update caches in workflows * Try to disable lint cache * Restore lint cache * Cache contracts-preprocessed * try to debug lint * Regenerate yarn.lock from dev * Restore correct deps * Update lock * Proposed improvements/fixes * Use fast-glob instead glob * Update bootloader_test artifact path * Proposed improvements, update hashes * Implement some fixes and improvements * Fix lints * Update zksync-era in bootloader tests * Fix imports Signed-off-by: Danil <deniallugo@gmail.com> * Update contracts/test-contracts/MockContract.sol Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> * Fix test infra * data -> input mock contract * Update SC hashes * Update zksync-era in bootloader/test_infra * Update again --------- Signed-off-by: Danil <deniallugo@gmail.com> Co-authored-by: Danil <deniallugo@gmail.com> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
kelemeno
requested review from
StanislavBreadless and
vladbochok
as code owners
StanislavBreadless
suggested changes
Dec 15, 2023
Collaborator
StanislavBreadless
left a comment
StanislavBreadless
left a comment
There was a problem hiding this comment.
Overall looks good & minimalistic.
I put the "request changes" so we don't merge it until the zksync-web3 dependency is fixed
…into sync-sc-dev # Conflicts: # scripts/process.ts # system/contracts/test-contracts/Callable.sol # system/contracts/test-contracts/DummyUpgrade.sol # system/contracts/test-contracts/EventWriterTest.sol # system/contracts/test-contracts/ExtraAbiCaller.zasm # system/contracts/test-contracts/MockContract.sol # system/contracts/test-contracts/MockERC20Approve.sol # system/contracts/test-contracts/MockKnownCodesStorage.sol # system/contracts/test-contracts/MockL1Messenger.sol # system/contracts/test-contracts/NotSystemCaller.sol # system/contracts/test-contracts/TestSystemContract.sol # system/contracts/test-contracts/TestSystemContractHelper.sol # system/scripts/compile-zasm.ts # system/scripts/preprocess-bootloader.ts # system/scripts/preprocess-system-contracts.ts # system/scripts/process.ts # system/scripts/quick-setup.sh # system/test/EcAdd.spec.ts # system/test/EcMul.spec.ts # system/test/shared/extraAbiCaller.ts # system/test/shared/mocks.ts # test/EcAdd.spec.ts # test/EcMul.spec.ts # test/precompiles/EcAdd.spec.ts # test/precompiles/EcMul.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
There are minimal changes to the interfaces due to contract changes.
The main change is the setChainId in the system context contract.
Why ❔
Checklist