[mlir][Sol] Support all event arg types in EmitOp lowering

[abinavpp]

NomicFoundation/solx-solidity#125

[Copilot]

Pull request overview

This PR updates the Solidity→Yul lowering of sol.emit to better match EVM log topic rules by transforming indexed event arguments into the form expected by yul.log topics, including hashing reference-typed indexed arguments. It also tightens normalizeABIScalarForEncoding to hard-fail when invoked on unsupported (non-scalar) types.

Changes:

• Lower indexed reference-typed event args (string/array/struct) to keccak256(abiPackedEncode(arg)) before passing as log topics.
• Normalize indexed value-typed args to i256 via normalizeABIScalarForEncoding (topics are i256).
• Replace the previous fallback return val; in normalizeABIScalarForEncoding with an llvm_unreachable for non-scalar types.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
mlir/lib/Conversion/SolToStandard/SolToYul.cpp	Updates EmitOp lowering to hash reference-type indexed args and normalize scalar indexed args to i256 topics.
mlir/lib/Conversion/SolToStandard/EVMUtil.cpp	Makes normalizeABIScalarForEncoding explicitly unreachable on non-scalar inputs (no silent passthrough).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 0af903a14710e4a1151d6a9dce67542d0f815f9a d558d0d7a2c0470185ac3f2183f60ca6bd3b162e -- mlir/lib/Conversion/SolToYul/SolToYul.cpp

View the diff from clang-format here.

diff --git a/mlir/lib/Conversion/SolToYul/SolToYul.cpp b/mlir/lib/Conversion/SolToYul/SolToYul.cpp
index 00fc4bf837dc..e251e1ac1c75 100644
--- a/mlir/lib/Conversion/SolToYul/SolToYul.cpp
+++ b/mlir/lib/Conversion/SolToYul/SolToYul.cpp
@@ -3393,8 +3393,7 @@ struct EmitOpLowering : public OpConversionPattern<sol::EmitOp> {
         Value scratchStart = evmB.genFreePtr();
         Value scratchEnd =
             evmB.genABIPackedEncoding(origTy, val, scratchStart, loc);
-        Value scratchSize =
-            r.create<yul::SubOp>(loc, scratchEnd, scratchStart);
+        Value scratchSize = r.create<yul::SubOp>(loc, scratchEnd, scratchStart);
         indexedArgs.push_back(
             r.create<yul::Keccak256Op>(loc, scratchStart, scratchSize));
         continue;

[vladimirradosavljevic]

LGTM, thanks!