fix: made metadata more similar to program proof, avoid second recursion #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-zk
added a commit
that referenced
this pull request
May 29, 2025
…ion (#2) ## What ❔ * Added proof-final option to CLI to take the recursion proof from zksmith, and do the final wrapping only * Made proof-metadata more similar to programProof (probably in future PRs we'll merge them together) * avoided unnecessary second recursion, when proving really small programs.
6 tasks
0xVolosnikov
pushed a commit
that referenced
this pull request
May 29, 2025
#12) …ion (#2) ## What ❔ * Added proof-final option to CLI to take the recursion proof from zksmith, and do the final wrapping only * Made proof-metadata more similar to programProof (probably in future PRs we'll merge them together) * avoided unnecessary second recursion, when proving really small programs. ## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted.
EmilLuta
pushed a commit
that referenced
this pull request
Dec 19, 2025
This PR bumps the MAX_FLAT_COL_IDXS constant to 3520, previous value caused a failure during bigint delegation circuit proving. This PR also adds a test to call the proving function with dummy inputs for each circuits to check for such failures.
EmilLuta
pushed a commit
that referenced
this pull request
Dec 19, 2025
This PR bumps the MAX_FLAT_COL_IDXS constant to 3520, previous value caused a failure during bigint delegation circuit proving. This PR also adds a test to call the proving function with dummy inputs for each circuits to check for such failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔