test: add last_evaluations verification in sumcheck loop#219
Merged
yoaveshel merged 4 commits intoav_gkr_compilerfrom Mar 4, 2026
Merged
test: add last_evaluations verification in sumcheck loop#219yoaveshel merged 4 commits intoav_gkr_compilerfrom
last_evaluations verification in sumcheck loop#219yoaveshel merged 4 commits intoav_gkr_compilerfrom
Conversation
Member
|
I'm curious if const fns are AI artifacts or intentional? Otherwise good by me |
shamatar
approved these changes
Mar 4, 2026
Author
|
@shamatar actually it's from clippy (I usually run it with nursery and pedantic to see if it has any good suggestions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Is this a breaking change?
Checklist