test: stabilize CI unit tests with runtime CI skips and legacy gating#221
Merged
test: stabilize CI unit tests with runtime CI skips and legacy gating#221
Conversation
robik75
changed the title
robik75
force-pushed
the
rr/fix-unit-tests
branch
from
688c6a6 to
67f477c
Compare
popzxc
reviewed
Mar 3, 2026
Member
popzxc
left a comment
popzxc
left a comment
There was a problem hiding this comment.
Generally looks good, just want to double check wrt changes in circuits. Also, the CI is red because of that I guess.
circuit_defs/unrolled_circuits/jump_branch_slt/generated/circuit_layout.rs
Outdated
Show resolved
Hide resolved
popzxc
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Stabilize workspace unit testing by:
CI-env skips for CI-inappropriate tests (codegen/artifact writers and similar non-CI-safe cases),legacy_tests,Why ❔
cargo test --profile cliin CI was unstable due to generated-artifact writers, legacy fixture dependencies, and very heavy proving tests. This keeps local workflows available while making CI deterministic and clean.Is this a breaking change?
Checklist