Skip to content

Conversation

@mm-zk
Copy link
Contributor

@mm-zk mm-zk commented May 26, 2025

What ❔

  • Added keccak_32 implementation that can run on reduced machine
  • In universal verifier - added option to combine 2 proofs with same verification keys together (and their 'public input' will be the keccak of the inputs)
  • added flatten-two command in CLI that combines 2 proofs together.
  • added CI to test this case.

Why ❔

This allows us to implement 'ohbender' - where we would merge the current proof with the previous one - therefore creating a 'chained' proof, which can be snark-wrapped once.

@github-actions
Copy link
Contributor

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(zk_evm): Expose more public methods
  • fix(zkevm_test_harness): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

Unknown release type "WIP" found in pull request title "WIP: Incremental aggregation". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@mm-zk mm-zk changed the title WIP: Incremental aggregation feat: Incremental aggregation (ohbender) Jun 10, 2025
@mm-zk mm-zk marked this pull request as ready for review June 10, 2025 20:10
@mm-zk mm-zk requested a review from 0xVolosnikov June 10, 2025 20:10
@mm-zk mm-zk changed the title feat: Incremental aggregation (ohbender) feat: Incremental aggregation - ohbender Jun 10, 2025
@mm-zk mm-zk changed the title feat: Incremental aggregation - ohbender feat: Incremental aggregation ohbender Jun 10, 2025
Copy link
Contributor

@0xVolosnikov 0xVolosnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mm-zk mm-zk merged commit 76b3647 into main Jun 11, 2025
24 of 26 checks passed
@mm-zk mm-zk deleted the mmzk_0525_ohbender branch June 11, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants