Skip to content

fix: return min refund when gas_price=0 #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimazhornyk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return min refund when gas_price=0 #3363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/lib/multivm/src/versions/vm_latest/tracers/refunds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ impl<S> RefundsTracer<S> {

// For now, bootloader charges only for base fee.
let effective_gas_price = get_batch_base_fee(&self.l1_batch);
if effective_gas_price == 0 {
Copy link
Contributor

@StanislavBreadless StanislavBreadless Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked in private: it is a breaking change, but most likely it is fine. Still, it is better to be able to somehow check that the partners (and Era itself) are not affected

Copy link
Contributor

@ischasny ischasny Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @StanislavBreadless

  • What if we safeguard it behind a feature toggle?
  • What is the scenario that we need to check for?

return bootloader_refund;
}

let bootloader_eth_price_per_pubdata_byte =
U256::from(effective_gas_price) * U256::from(current_ergs_per_pubdata_byte);
Expand Down
Loading