fix: zkstack readme update broken links and wording #3375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zk-Lumi
changed the title
popzxc
approved these changes
Dec 12, 2024
Member
|
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ Hi @Deniallugo @popzxc 👋 Was playing with zkstack cli today. This PR is just fixing a couple of broken links and updating a bit of wording in `zkstack_cli/README.md`. PS: sidenote, "EVM emulator" is not explained in this readme, and "Enable EVM emulator?" in interactive mode will be confusing to people (they likely wont realize that it is emulating EVM equivalence but not required for most chains + will be more expensive) ## Why ❔ Possibly a bit OCD, ie "Zk" being wrongly cased in one instance stayed in my mind and bothered me hahahah 😉 <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Hi @Deniallugo @popzxc 👋
Was playing with zkstack cli today.
This PR is just fixing a couple of broken links and updating a bit of wording in
zkstack_cli/README.md.PS: sidenote, "EVM emulator" is not explained in this readme, and "Enable EVM emulator?" in interactive mode will be confusing to people (they likely wont realize that it is emulating EVM equivalence but not required for most chains + will be more expensive)
Why ❔
Possibly a bit OCD, ie "Zk" being wrongly cased in one instance stayed in my mind and bothered me hahahah 😉
Checklist
zkstack dev fmtandzkstack dev lint.