feat: Update EVM emulator feature in zkstack and zk #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Dec 19, 2024
Contributor
slowli
left a comment
slowli
left a comment
There was a problem hiding this comment.
AFAIU, zk is no longer maintained. I guess it wouldn't harm to include new functionality into it, but I wouldn't spend much effort on it.
zkstack_cli/crates/config/src/forge_interface/enable_evm_emulator/mod.rs
Outdated
Show resolved
Hide resolved
slowli
approved these changes
Dec 19, 2024
zkstack_cli/crates/zkstack/src/commands/chain/enable_evm_emulator.rs
Outdated
Show resolved
Hide resolved
zkstack_cli/crates/zkstack/src/commands/chain/enable_evm_emulator.rs
Outdated
Show resolved
Hide resolved
slowli
previously approved these changes
Dec 19, 2024
slowli
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
0xVolosnikov
deleted the
vv-update-evm-emulator-feature-in-zkstack-and-zk
branch
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ Following the latest changes to the EVM emulator contracts, the process for enabling the EVM emulator has changed. ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [X] Documentation comments have been added / updated. - [X] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Following the latest changes to the EVM emulator contracts, the process for enabling the EVM emulator has changed.
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.