-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Reduction of diff between main and sync-layer-stable #3400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Dec 18, 2024
core/node/node_framework/src/implementations/layers/eth_sender/aggregator.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/eth_watch.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/pk_signing_eth_client.rs
Outdated
Show resolved
Hide resolved
slowli
reviewed
Dec 19, 2024
Contributor
slowli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good.
core/node/node_framework/src/implementations/layers/eth_sender/aggregator.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/eth_sender/aggregator.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/eth_sender/aggregator.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/pk_signing_eth_client.rs
Show resolved
Hide resolved
slowli
previously approved these changes
Dec 19, 2024
core/node/node_framework/src/implementations/layers/eth_watch.rs
Outdated
Show resolved
Hide resolved
kelemeno
approved these changes
Dec 20, 2024
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ This PR includes: - Changes to VM. Note, that since they are only activated during usage of the new ProtocolVersion, they should not affect the current behavior. - Changes to the VM introduce the max new factory deps as equal to 64 (but only to the last subversion) - The block reverted made to work on top of gateway, but most of the diff is due to the removal of the support for env-based instead of file based inputs - Gateway config ported - Some various changes to gateway-specific logic that should not be active before the upgrade ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR includes:
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.