Skip to content

Conversation

@StanislavBreadless
Copy link
Contributor

@StanislavBreadless StanislavBreadless commented Dec 18, 2024

What ❔

This PR includes:

  • Changes to VM. Note, that since they are only activated during usage of the new ProtocolVersion, they should not affect the current behavior.
  • Changes to the VM introduce the max new factory deps as equal to 64 (but only to the last subversion)
  • The block reverted made to work on top of gateway, but most of the diff is due to the removal of the support for env-based instead of file based inputs
  • Gateway config ported
  • Some various changes to gateway-specific logic that should not be active before the upgrade

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@StanislavBreadless StanislavBreadless changed the title Reduction of diff between main and sync-layer-stable chore: Reduction of diff between main and sync-layer-stable Dec 18, 2024
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.

slowli
slowli previously approved these changes Dec 19, 2024
@StanislavBreadless StanislavBreadless added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit ea18999 Dec 20, 2024
32 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-sls-main-diff-reduction branch December 20, 2024 10:03
zkzoomer pushed a commit that referenced this pull request Jun 21, 2025
## What ❔

This PR includes:
- Changes to VM. Note, that since they are only activated during usage
of the new ProtocolVersion, they should not affect the current behavior.
- Changes to the VM introduce the max new factory deps as equal to 64
(but only to the last subversion)
- The block reverted made to work on top of gateway, but most of the
diff is due to the removal of the support for env-based instead of file
based inputs
- Gateway config ported
- Some various changes to gateway-specific logic that should not be
active before the upgrade

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants