feat(tee): add support for recoverable signatures #3414

pbeza · 2024-12-30T14:28:40Z

What ❔

This PR is part of the effort to implement on-chain TEE proof verification. Signatures produced by the TEE Prover are now compatible with the on-chain verifier that uses the ecrecover precompile.

Why ❔

Until now, we've been using non-recoverable signatures in the TEE prover with a compressed ECDSA public key in each attestation – it was compressed because there are only 64 bytes available in the report attestation quote. That worked fine for off-chain proof verification, but for on-chain verification, it's better to use the Ethereum address derived from the public key so we can call ecrecover in Solidity to verify the signature.

This PR goes hand in hand with:

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zkstack dev fmt and zkstack dev lint.

…report_data This PR goes hand in hand with matter-labs/zksync-era#3414

This PR is part of the effort to implement on-chain TEE proof verification. Signatures produced by the TEE Prover are now compatible with the on-chain verifier that uses the `ecrecover` precompile. Until now, we've been using _non-recoverable_ signatures in the TEE prover with a compressed ECDSA public key in each attestation -- it was compressed because there are only 64 bytes available in the report attestation quote. That worked fine for off-chain proof verification, but for on-chain verification, it's better to use the Ethereum address derived from the public key so we can call ecrecover in Solidity to verify the signature. This PR goes hand in hand with matter-labs/teepot#228

…report_data This PR is part of the effort to implement on-chain TEE proof verification. This PR goes hand in hand with matter-labs/zksync-era#3414.

…in report_data This PR is part of the effort to implement on-chain TEE proof verification. This PR goes hand in hand with: - matter-labs/zksync-era#3414 - #228

…report_data This PR is part of the effort to implement on-chain TEE proof verification. This PR goes hand in hand with matter-labs/zksync-era#3414.

…in report_data This PR is part of the effort to implement on-chain TEE proof verification. This PR goes hand in hand with: - matter-labs/zksync-era#3414 - #228

core/bin/zksync_tee_prover/src/tee_prover.rs

core/bin/zksync_tee_prover/Cargo.toml

…patible-recoverable-signatures

…report_data This PR is part of the effort to implement on-chain TEE proof verification. This PR goes hand in hand with matter-labs/zksync-era#3414.

Signed-off-by: Harald Hoyer <[email protected]>

…patible-recoverable-signatures

slowli

Other than what looks like an overly complex construction of a secret key, looks good 👍

core/bin/zksync_tee_prover/src/tee_prover.rs

pbeza · 2025-02-07T12:06:20Z

JFYI, @haraldh, it's ready to merge. ✅🫡

🤖 I have created a release *beep* *boop* --- ## [26.5.0](core-v26.4.0...core-v26.5.0) (2025-03-03) ### Features * add a flag for stage1->stage2 validium migration ([#3562](#3562)) ([92e7895](92e7895)) * add custom DA support in external node ([#3445](#3445)) ([1a8546d](1a8546d)) * **contract-verifier:** add Etherscan contract verification ([#3609](#3609)) ([a4ea0f2](a4ea0f2)) * **da-clients:** raise Avail blob size to 1mb ([#3624](#3624)) ([0baa7ff](0baa7ff)) * **eigenda:** implement eigenDA client remaining features ([#3243](#3243)) ([88fc971](88fc971)) * preparation for new precompiles ([#3535](#3535)) ([3c1f3fb](3c1f3fb)) * **tee:** add support for recoverable signatures ([#3414](#3414)) ([7241a73](7241a73)) * **zkos:** Implement ZK OS Merkle tree ([#3625](#3625)) ([331e98c](331e98c)) ### Bug Fixes * **api:** Fix pending transactions filter again ([#3630](#3630)) ([7afa20f](7afa20f)) * **api:** lock simultaneous tx insertsion with mutex ([#3616](#3616)) ([644b621](644b621)) * block.timestamp is not accurate ([#3398](#3398)) ([adcb517](adcb517)) * Fflonk versioning ([#3610](#3610)) ([fc80840](fc80840)) * Limit number of connections open for GCS interactions ([#3637](#3637)) ([6b003e2](6b003e2)) ### Performance Improvements * **api:** Use watch channel in values cache updates ([#3663](#3663)) ([3a4bdcf](3a4bdcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [26.5.0](core-v26.4.0...core-v26.5.0) (2025-03-03) ### Features * add a flag for stage1->stage2 validium migration ([#3562](#3562)) ([92e7895](92e7895)) * add custom DA support in external node ([#3445](#3445)) ([db31e71](db31e71)) * **contract-verifier:** add Etherscan contract verification ([#3609](#3609)) ([f13bd80](f13bd80)) * **da-clients:** raise Avail blob size to 1mb ([#3624](#3624)) ([0baa7ff](0baa7ff)) * **eigenda:** implement eigenDA client remaining features ([#3243](#3243)) ([161da42](161da42)) * preparation for new precompiles ([#3535](#3535)) ([3c1f3fb](3c1f3fb)) * **tee:** add support for recoverable signatures ([#3414](#3414)) ([7241a73](7241a73)) * **zkos:** Implement ZK OS Merkle tree ([#3625](#3625)) ([331e98c](331e98c)) ### Bug Fixes * **api:** Fix pending transactions filter again ([#3630](#3630)) ([7afa20f](7afa20f)) * **api:** lock simultaneous tx insertsion with mutex ([#3616](#3616)) ([644b621](644b621)) * block.timestamp is not accurate ([#3398](#3398)) ([adcb517](adcb517)) * Fflonk versioning ([#3610](#3610)) ([fc80840](fc80840)) * Limit number of connections open for GCS interactions ([#3637](#3637)) ([6b003e2](6b003e2)) ### Performance Improvements * **api:** Use watch channel in values cache updates ([#3663](#3663)) ([3a4bdcf](3a4bdcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [26.5.0](matter-labs/zksync-era@core-v26.4.0...core-v26.5.0) (2025-03-03) ### Features * add a flag for stage1->stage2 validium migration ([#3562](matter-labs/zksync-era#3562)) ([92e7895](matter-labs/zksync-era@92e7895)) * add custom DA support in external node ([#3445](matter-labs/zksync-era#3445)) ([4ca2e03](matter-labs/zksync-era@4ca2e03)) * **contract-verifier:** add Etherscan contract verification ([#3609](matter-labs/zksync-era#3609)) ([180cd32](matter-labs/zksync-era@180cd32)) * **da-clients:** raise Avail blob size to 1mb ([#3624](matter-labs/zksync-era#3624)) ([0baa7ff](matter-labs/zksync-era@0baa7ff)) * **eigenda:** implement eigenDA client remaining features ([#3243](matter-labs/zksync-era#3243)) ([771e6f0](matter-labs/zksync-era@771e6f0)) * preparation for new precompiles ([#3535](matter-labs/zksync-era#3535)) ([3c1f3fb](matter-labs/zksync-era@3c1f3fb)) * **tee:** add support for recoverable signatures ([#3414](matter-labs/zksync-era#3414)) ([7241a73](matter-labs/zksync-era@7241a73)) * **zkos:** Implement ZK OS Merkle tree ([#3625](matter-labs/zksync-era#3625)) ([331e98c](matter-labs/zksync-era@331e98c)) ### Bug Fixes * **api:** Fix pending transactions filter again ([#3630](matter-labs/zksync-era#3630)) ([7afa20f](matter-labs/zksync-era@7afa20f)) * **api:** lock simultaneous tx insertsion with mutex ([#3616](matter-labs/zksync-era#3616)) ([644b621](matter-labs/zksync-era@644b621)) * block.timestamp is not accurate ([#3398](matter-labs/zksync-era#3398)) ([adcb517](matter-labs/zksync-era@adcb517)) * Fflonk versioning ([#3610](matter-labs/zksync-era#3610)) ([fc80840](matter-labs/zksync-era@fc80840)) * Limit number of connections open for GCS interactions ([#3637](matter-labs/zksync-era#3637)) ([6b003e2](matter-labs/zksync-era@6b003e2)) ### Performance Improvements * **api:** Use watch channel in values cache updates ([#3663](matter-labs/zksync-era#3663)) ([3a4bdcf](matter-labs/zksync-era@3a4bdcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>

pbeza force-pushed the tee/feat/solidity-compatible-recoverable-signatures branch 4 times, most recently from 9c15a1b to 1c239e7 Compare December 30, 2024 17:28

pbeza requested review from haraldh and slowli December 30, 2024 17:46

pbeza mentioned this pull request Dec 30, 2024

feat(tee-key-preexec): support for Solidity-compatible pubkey in report_data matter-labs/teepot#228

Closed

pbeza added a commit to matter-labs/teepot that referenced this pull request Dec 30, 2024

feat(tee-key-preexec): add support for Solidity-compatible pubkey in …

e95728f

…report_data This PR goes hand in hand with matter-labs/zksync-era#3414

pbeza force-pushed the tee/feat/solidity-compatible-recoverable-signatures branch from 1c239e7 to 63a7712 Compare December 31, 2024 10:08

pbeza mentioned this pull request Dec 31, 2024

feat(tee-proof-verifier): add support for Solidity-compatible pubkey in report_data matter-labs/teepot#240

Closed

haraldh suggested changes Jan 7, 2025

View reviewed changes

core/bin/zksync_tee_prover/src/tee_prover.rs Outdated Show resolved Hide resolved

slowli reviewed Jan 10, 2025

View reviewed changes

core/bin/zksync_tee_prover/src/tee_prover.rs Outdated Show resolved Hide resolved

core/bin/zksync_tee_prover/Cargo.toml Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into tee/feat/solidity-com…

b380bc6

…patible-recoverable-signatures

pbeza force-pushed the tee/feat/solidity-compatible-recoverable-signatures branch 2 times, most recently from 279292a to c801dd7 Compare January 14, 2025 13:38

Address code review comments

27ad86e

pbeza force-pushed the tee/feat/solidity-compatible-recoverable-signatures branch from c801dd7 to 27ad86e Compare January 14, 2025 15:16

pbeza requested a review from slowli January 14, 2025 15:39

haraldh and others added 4 commits January 17, 2025 14:07

chore(nix): flake update

fde44e0

Signed-off-by: Harald Hoyer <[email protected]>

Merge remote-tracking branch 'origin/main' into tee/feat/solidity-com…

01978a8

…patible-recoverable-signatures

Merge remote-tracking branch 'origin/main' into tee/feat/solidity-com…

30ca549

…patible-recoverable-signatures

Address code review comments

d09d87b

pbeza force-pushed the tee/feat/solidity-compatible-recoverable-signatures branch from 2fc26b3 to d09d87b Compare January 30, 2025 11:24

slowli reviewed Jan 31, 2025

View reviewed changes

core/bin/zksync_tee_prover/src/tee_prover.rs Outdated Show resolved Hide resolved

Address another round of review comments

b4fcf43

slowli previously approved these changes Feb 6, 2025

View reviewed changes

core/bin/zksync_tee_prover/src/tee_prover.rs Outdated Show resolved Hide resolved

core/bin/zksync_tee_prover/src/tee_prover.rs Outdated Show resolved Hide resolved

core/bin/zksync_tee_prover/src/tee_prover.rs Outdated Show resolved Hide resolved

pbeza dismissed slowli’s stale review via 1f00597 February 6, 2025 17:59

Yet another round of review comment fixes

d9855db

pbeza force-pushed the tee/feat/solidity-compatible-recoverable-signatures branch from 1f00597 to d9855db Compare February 6, 2025 18:09

slowli approved these changes Feb 6, 2025

View reviewed changes

haraldh enabled auto-merge February 17, 2025 14:47

haraldh approved these changes Feb 17, 2025

View reviewed changes

haraldh added this pull request to the merge queue Feb 17, 2025

Merged via the queue into main with commit 7241a73 Feb 17, 2025
33 checks passed

haraldh deleted the tee/feat/solidity-compatible-recoverable-signatures branch February 17, 2025 15:30

github-actions bot mentioned this pull request Feb 17, 2025

chore(main): release core 26.5.0 #3612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tee): add support for recoverable signatures #3414

feat(tee): add support for recoverable signatures #3414

Uh oh!

pbeza commented Dec 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slowli left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbeza commented Feb 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(tee): add support for recoverable signatures #3414

feat(tee): add support for recoverable signatures #3414

Uh oh!

Conversation

pbeza commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What ❔

Why ❔

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slowli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pbeza commented Feb 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pbeza commented Dec 30, 2024 •

edited

Loading