chore: Reduce diff with sync layer stable (zkstack) #3416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavBreadless
changed the title
StanislavBreadless
changed the title
perekopskiy
reviewed
Jan 2, 2025
Contributor
perekopskiy
left a comment
perekopskiy
left a comment
There was a problem hiding this comment.
let's resolve/drop/mark todos without task id, otherwise we risk forgetting about them
zkstack_cli/crates/config/src/forge_interface/gateway_ecosystem_upgrade/input.rs
Outdated
Show resolved
Hide resolved
zkstack_cli/crates/zkstack/src/commands/chain/migrate_to_gateway.rs
Outdated
Show resolved
Hide resolved
Collaborator
sanekmelnikov
left a comment
sanekmelnikov
left a comment
There was a problem hiding this comment.
Appreciate splitting the CLI interface portion - makes review much easier!
Rechecked that merging this won't break any existing flows for zkstack.
--zksync-related comment is probably the one that I'd ask to address in this PR, as it's unnecessarily user facing and easy to fix.
All the other comments can be addressed in future PRs.
zkstack_cli/crates/config/src/forge_interface/gateway_ecosystem_upgrade/input.rs
Show resolved
Hide resolved
perekopskiy
approved these changes
Jan 3, 2025
sanekmelnikov
approved these changes
Jan 3, 2025
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ Introduces functions to the zkstack related to Gateway. These are included into the libraries, but are not included into the users interface (CLI itself) and a lot of places contain TODO(EVM-927) to indicate that those are not usable before the Gateway contracts have been merged. Also, as per discussions with @sanekmelnikov it is okay that the first iteration of gateway scripts (esp since those are not usable by the partners yet) use println instead of spinners that are more commonly used in zkstack. For this we have a followup task: EVM-928 ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Introduces functions to the zkstack related to Gateway. These are included into the libraries, but are not included into the users interface (CLI itself) and a lot of places contain TODO(EVM-927) to indicate that those are not usable before the Gateway contracts have been merged.
Also, as per discussions with @sanekmelnikov it is okay that the first iteration of gateway scripts (esp since those are not usable by the partners yet) use println instead of spinners that are more commonly used in zkstack. For this we have a followup task: EVM-928
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.