refactor: rename zkstack crates with unique names for publishing #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
reviewed
Jan 8, 2025
Member
popzxc
left a comment
popzxc
left a comment
There was a problem hiding this comment.
Could you rename it to zkstack_cli_* (because zkstack as a term has different meaning)?
antonbaliasnikov
force-pushed
the
aba-rename-zkstack-cli-crates
branch
from
4a4ed74 to
4781e93
Compare
antonbaliasnikov
force-pushed
the
aba-rename-zkstack-cli-crates
branch
from
4781e93 to
634b04e
Compare
Contributor
Author
@popzxc , sure! Reworked to |
popzxc
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ * [x] Rename `zkstack_cli` crates with unique names for publishing. * [x] Set individual versions of the `zkstack_cli` workspace crates to the common workspace version. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ To allow publishing to crates.io. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
zkstack_clicrates with unique names for publishing.zkstack_cliworkspace crates to the common workspace version.Why ❔
To allow publishing to crates.io.
Checklist
zkstack dev fmtandzkstack dev lint.