feat: add custom DA support in external node #3445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Restore revert test
feat: Restore offline chain creation
feat: merge upstream
test: fix revert test flakiness
feat: use new foundry version
perekopskiy
reviewed
Feb 24, 2025
perekopskiy
previously approved these changes
Feb 24, 2025
slowli
reviewed
Feb 24, 2025
Contributor
slowli
left a comment
slowli
left a comment
There was a problem hiding this comment.
Other than env-based config param naming, looks good.
slowli
reviewed
Feb 25, 2025
slowli
approved these changes
Feb 27, 2025
alexandrst88
approved these changes
Feb 27, 2025
This was referenced Feb 26, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
🤖 I have created a release *beep* *boop* --- ## [26.5.0](core-v26.4.0...core-v26.5.0) (2025-03-03) ### Features * add a flag for stage1->stage2 validium migration ([#3562](#3562)) ([92e7895](92e7895)) * add custom DA support in external node ([#3445](#3445)) ([1a8546d](1a8546d)) * **contract-verifier:** add Etherscan contract verification ([#3609](#3609)) ([a4ea0f2](a4ea0f2)) * **da-clients:** raise Avail blob size to 1mb ([#3624](#3624)) ([0baa7ff](0baa7ff)) * **eigenda:** implement eigenDA client remaining features ([#3243](#3243)) ([88fc971](88fc971)) * preparation for new precompiles ([#3535](#3535)) ([3c1f3fb](3c1f3fb)) * **tee:** add support for recoverable signatures ([#3414](#3414)) ([7241a73](7241a73)) * **zkos:** Implement ZK OS Merkle tree ([#3625](#3625)) ([331e98c](331e98c)) ### Bug Fixes * **api:** Fix pending transactions filter again ([#3630](#3630)) ([7afa20f](7afa20f)) * **api:** lock simultaneous tx insertsion with mutex ([#3616](#3616)) ([644b621](644b621)) * block.timestamp is not accurate ([#3398](#3398)) ([adcb517](adcb517)) * Fflonk versioning ([#3610](#3610)) ([fc80840](fc80840)) * Limit number of connections open for GCS interactions ([#3637](#3637)) ([6b003e2](6b003e2)) ### Performance Improvements * **api:** Use watch channel in values cache updates ([#3663](#3663)) ([3a4bdcf](3a4bdcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
🤖 I have created a release *beep* *boop* --- ## [19.0.0](prover-v18.0.0...prover-v19.0.0) (2025-03-04) ### ⚠ BREAKING CHANGES * Combine GPU and simple Scaler into single Scaler ([#3621](#3621)) ### Features * add custom DA support in external node ([#3445](#3445)) ([1a8546d](1a8546d)) * **contract-verifier:** Partial matching & automatic verification ([#3527](#3527)) ([bf9fe85](bf9fe85)) * make `zksync_types` thinner ([#3574](#3574)) ([e7f93e4](e7f93e4)) * preparation for new precompiles ([#3535](#3535)) ([3c1f3fb](3c1f3fb)) * **prover:** Add gpu_checker binary ([#3573](#3573)) ([51b9a03](51b9a03)) * Refactor WG DAL ([#3560](#3560)) ([d1ede36](d1ede36)) * Rework prover job handling ([#3561](#3561)) ([ddc4243](ddc4243)) * Updating information about keys & commitments for releases ([#3486](#3486)) ([cd21c9e](cd21c9e)) * **vm:** Allow caching signature verification ([#3505](#3505)) ([7bb5ed3](7bb5ed3)) ### Bug Fixes * Add autoscaler_queue metric back ([#3668](#3668)) ([7f36ed9](7f36ed9)) * Allow witness_generator to use Prometheus push gateway in continuous mode ([#3555](#3555)) ([0f1a5e0](0f1a5e0)) * Simplify prover_jobs_fri indices ([#3577](#3577)) ([559edc3](559edc3)) ### Performance Improvements * Add prover jobs as one multi-insert for Witness Generator ([#3587](#3587)) ([d150dca](d150dca)) ### Code Refactoring * Combine GPU and simple Scaler into single Scaler ([#3621](#3621)) ([8e24403](8e24403)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ Enable DA info fetching in External Node. ## Why ❔ It is important because DA info is used to construct `commitBatches` transactions, which means for any custom L1DAValidator the consistency checker will fail to produce the same payload without it. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Stanislav Breadless <[email protected]> Co-authored-by: perekopskiy <[email protected]> Co-authored-by: perekopskiy <[email protected]> Co-authored-by: Marcin M <[email protected]>
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
🤖 I have created a release *beep* *boop* --- ## [26.5.0](core-v26.4.0...core-v26.5.0) (2025-03-03) ### Features * add a flag for stage1->stage2 validium migration ([#3562](#3562)) ([92e7895](92e7895)) * add custom DA support in external node ([#3445](#3445)) ([db31e71](db31e71)) * **contract-verifier:** add Etherscan contract verification ([#3609](#3609)) ([f13bd80](f13bd80)) * **da-clients:** raise Avail blob size to 1mb ([#3624](#3624)) ([0baa7ff](0baa7ff)) * **eigenda:** implement eigenDA client remaining features ([#3243](#3243)) ([161da42](161da42)) * preparation for new precompiles ([#3535](#3535)) ([3c1f3fb](3c1f3fb)) * **tee:** add support for recoverable signatures ([#3414](#3414)) ([7241a73](7241a73)) * **zkos:** Implement ZK OS Merkle tree ([#3625](#3625)) ([331e98c](331e98c)) ### Bug Fixes * **api:** Fix pending transactions filter again ([#3630](#3630)) ([7afa20f](7afa20f)) * **api:** lock simultaneous tx insertsion with mutex ([#3616](#3616)) ([644b621](644b621)) * block.timestamp is not accurate ([#3398](#3398)) ([adcb517](adcb517)) * Fflonk versioning ([#3610](#3610)) ([fc80840](fc80840)) * Limit number of connections open for GCS interactions ([#3637](#3637)) ([6b003e2](6b003e2)) ### Performance Improvements * **api:** Use watch channel in values cache updates ([#3663](#3663)) ([3a4bdcf](3a4bdcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>
dutterbutter
pushed a commit
to dutterbutter/zkstack-cli
that referenced
this pull request
Jul 3, 2025
🤖 I have created a release *beep* *boop* --- ## [26.5.0](matter-labs/zksync-era@core-v26.4.0...core-v26.5.0) (2025-03-03) ### Features * add a flag for stage1->stage2 validium migration ([#3562](matter-labs/zksync-era#3562)) ([92e7895](matter-labs/zksync-era@92e7895)) * add custom DA support in external node ([#3445](matter-labs/zksync-era#3445)) ([4ca2e03](matter-labs/zksync-era@4ca2e03)) * **contract-verifier:** add Etherscan contract verification ([#3609](matter-labs/zksync-era#3609)) ([180cd32](matter-labs/zksync-era@180cd32)) * **da-clients:** raise Avail blob size to 1mb ([#3624](matter-labs/zksync-era#3624)) ([0baa7ff](matter-labs/zksync-era@0baa7ff)) * **eigenda:** implement eigenDA client remaining features ([#3243](matter-labs/zksync-era#3243)) ([771e6f0](matter-labs/zksync-era@771e6f0)) * preparation for new precompiles ([#3535](matter-labs/zksync-era#3535)) ([3c1f3fb](matter-labs/zksync-era@3c1f3fb)) * **tee:** add support for recoverable signatures ([#3414](matter-labs/zksync-era#3414)) ([7241a73](matter-labs/zksync-era@7241a73)) * **zkos:** Implement ZK OS Merkle tree ([#3625](matter-labs/zksync-era#3625)) ([331e98c](matter-labs/zksync-era@331e98c)) ### Bug Fixes * **api:** Fix pending transactions filter again ([#3630](matter-labs/zksync-era#3630)) ([7afa20f](matter-labs/zksync-era@7afa20f)) * **api:** lock simultaneous tx insertsion with mutex ([#3616](matter-labs/zksync-era#3616)) ([644b621](matter-labs/zksync-era@644b621)) * block.timestamp is not accurate ([#3398](matter-labs/zksync-era#3398)) ([adcb517](matter-labs/zksync-era@adcb517)) * Fflonk versioning ([#3610](matter-labs/zksync-era#3610)) ([fc80840](matter-labs/zksync-era@fc80840)) * Limit number of connections open for GCS interactions ([#3637](matter-labs/zksync-era#3637)) ([6b003e2](matter-labs/zksync-era@6b003e2)) ### Performance Improvements * **api:** Use watch channel in values cache updates ([#3663](matter-labs/zksync-era#3663)) ([3a4bdcf](matter-labs/zksync-era@3a4bdcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Enable DA info fetching in External Node.
Why ❔
It is important because DA info is used to construct
commitBatchestransactions, which means for any custom L1DAValidator the consistency checker will fail to produce the same payload without it.Checklist
zkstack dev fmtandzkstack dev lint.