fix(api): Change `contractAddress` assignment for transaction receipts #3452

slowli · 2025-01-10T10:46:17Z

What ❔

Changes how contractAddress is assigned for transaction receipts. With these changes, it is assigned for EVM deployment transactions (ones with to == None) and EraVM deployments (i.e., calls to ContractDeployer.{create, create2, createAccount, create2Account}) regardless of whether the transaction succeeds.

Why ❔

Improves EVM compatibility.

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zkstack dev fmt and zkstack dev lint.

slowli

This is a breaking change in terms of API. contractAddress will no longer be set for some of transactions (ones that we don't consider EraVM deployment txs). OTOH, it will be set for failed deployment txs.

core/lib/contract_verifier/src/lib.rs

core/lib/dal/src/models/storage_transaction.rs

core/node/api_server/src/utils.rs

perekopskiy

Looks good. I haven't checked protocol/nonce questions, so an approval from @0xVolosnikov would be nice to have

core/lib/dal/src/models/storage_transaction.rs

slowli · 2025-02-05T12:23:39Z

@0xVolosnikov I've disabled contractAddress computations for custom AAs; i.e., it's now always set to null for them.

🤖 I have created a release *beep* *boop* --- ## [26.3.0](core-v26.2.1...core-v26.3.0) (2025-02-12) ### Features * **contract-verifier:** Do not allow verification requests for verified contracts ([#3578](#3578)) ([6a1f1b8](6a1f1b8)) * **contract-verifier:** Partial matching & automatic verification ([#3527](#3527)) ([bf9fe85](bf9fe85)) * **contract-verifier:** Support missing options for EVM in API ([#3592](#3592)) ([309fdf4](309fdf4)) * **en:** better EN default req entities limit, improved documentation for API limits ([#3546](#3546)) ([e7eb716](e7eb716)) * make `zksync_types` thinner ([#3574](#3574)) ([e7f93e4](e7f93e4)) * new da_dispatcher metrics ([#3464](#3464)) ([75a7c08](75a7c08)) * update FFLONK protocol version ([#3572](#3572)) ([a352852](a352852)) * **vm:** Allow caching signature verification ([#3505](#3505)) ([7bb5ed3](7bb5ed3)) * **vm:** Support missed storage invocation limit in fast VM ([#3548](#3548)) ([ef67694](ef67694)) ### Bug Fixes * Add debug information to object store retries ([#3576](#3576)) ([036315c](036315c)) * allow configuring NoDA client via ENV ([#3599](#3599)) ([a72ab63](a72ab63)) * **api:** Change `contractAddress` assignment for transaction receipts ([#3452](#3452)) ([4179711](4179711)) * **api:** Improve estimation for gas_per_pubdata_limit ([#3475](#3475)) ([bda1b25](bda1b25)) * Avail gas relay decoding issues ([#3547](#3547)) ([a171433](a171433)) * **ci:** commenting out getFilterChanges test until fix is ready ([#3582](#3582)) ([99c3905](99c3905)) * Support newer versions of foundry-zksync ([#3556](#3556)) ([d39fb6d](d39fb6d)) * **vm:** Fix VM divergences related to validation ([#3567](#3567)) ([170d194](170d194)) ### Performance Improvements * **db:** Remove `events.tx_initiator_address` writes and index ([#3559](#3559)) ([298abd2](298abd2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [26.3.0](core-v26.2.1...core-v26.3.0) (2025-02-12) ### Features * **contract-verifier:** Do not allow verification requests for verified contracts ([#3578](#3578)) ([6a1f1b8](6a1f1b8)) * **contract-verifier:** Partial matching & automatic verification ([#3527](#3527)) ([b94d1ad](b94d1ad)) * **contract-verifier:** Support missing options for EVM in API ([#3592](#3592)) ([309fdf4](309fdf4)) * **en:** better EN default req entities limit, improved documentation for API limits ([#3546](#3546)) ([e7eb716](e7eb716)) * make `zksync_types` thinner ([#3574](#3574)) ([292e731](292e731)) * new da_dispatcher metrics ([#3464](#3464)) ([75a7c08](75a7c08)) * update FFLONK protocol version ([#3572](#3572)) ([a352852](a352852)) * **vm:** Allow caching signature verification ([#3505](#3505)) ([7bb5ed3](7bb5ed3)) * **vm:** Support missed storage invocation limit in fast VM ([#3548](#3548)) ([ef67694](ef67694)) ### Bug Fixes * Add debug information to object store retries ([#3576](#3576)) ([036315c](036315c)) * allow configuring NoDA client via ENV ([#3599](#3599)) ([a72ab63](a72ab63)) * **api:** Change `contractAddress` assignment for transaction receipts ([#3452](#3452)) ([4179711](4179711)) * **api:** Improve estimation for gas_per_pubdata_limit ([#3475](#3475)) ([bda1b25](bda1b25)) * Avail gas relay decoding issues ([#3547](#3547)) ([a171433](a171433)) * **ci:** commenting out getFilterChanges test until fix is ready ([#3582](#3582)) ([99c3905](99c3905)) * Support newer versions of foundry-zksync ([#3556](#3556)) ([d39fb6d](d39fb6d)) * **vm:** Fix VM divergences related to validation ([#3567](#3567)) ([170d194](170d194)) ### Performance Improvements * **db:** Remove `events.tx_initiator_address` writes and index ([#3559](#3559)) ([298abd2](298abd2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [26.3.0](matter-labs/zksync-era@core-v26.2.1...core-v26.3.0) (2025-02-12) ### Features * **contract-verifier:** Do not allow verification requests for verified contracts ([#3578](matter-labs/zksync-era#3578)) ([6a1f1b8](matter-labs/zksync-era@6a1f1b8)) * **contract-verifier:** Partial matching & automatic verification ([#3527](matter-labs/zksync-era#3527)) ([a0b7ca1](matter-labs/zksync-era@a0b7ca1)) * **contract-verifier:** Support missing options for EVM in API ([#3592](matter-labs/zksync-era#3592)) ([309fdf4](matter-labs/zksync-era@309fdf4)) * **en:** better EN default req entities limit, improved documentation for API limits ([#3546](matter-labs/zksync-era#3546)) ([e7eb716](matter-labs/zksync-era@e7eb716)) * make `zksync_types` thinner ([#3574](matter-labs/zksync-era#3574)) ([fc84832](matter-labs/zksync-era@fc84832)) * new da_dispatcher metrics ([#3464](matter-labs/zksync-era#3464)) ([75a7c08](matter-labs/zksync-era@75a7c08)) * update FFLONK protocol version ([#3572](matter-labs/zksync-era#3572)) ([a352852](matter-labs/zksync-era@a352852)) * **vm:** Allow caching signature verification ([#3505](matter-labs/zksync-era#3505)) ([7bb5ed3](matter-labs/zksync-era@7bb5ed3)) * **vm:** Support missed storage invocation limit in fast VM ([#3548](matter-labs/zksync-era#3548)) ([ef67694](matter-labs/zksync-era@ef67694)) ### Bug Fixes * Add debug information to object store retries ([#3576](matter-labs/zksync-era#3576)) ([036315c](matter-labs/zksync-era@036315c)) * allow configuring NoDA client via ENV ([#3599](matter-labs/zksync-era#3599)) ([a72ab63](matter-labs/zksync-era@a72ab63)) * **api:** Change `contractAddress` assignment for transaction receipts ([#3452](matter-labs/zksync-era#3452)) ([4179711](matter-labs/zksync-era@4179711)) * **api:** Improve estimation for gas_per_pubdata_limit ([#3475](matter-labs/zksync-era#3475)) ([bda1b25](matter-labs/zksync-era@bda1b25)) * Avail gas relay decoding issues ([#3547](matter-labs/zksync-era#3547)) ([a171433](matter-labs/zksync-era@a171433)) * **ci:** commenting out getFilterChanges test until fix is ready ([#3582](matter-labs/zksync-era#3582)) ([99c3905](matter-labs/zksync-era@99c3905)) * Support newer versions of foundry-zksync ([#3556](matter-labs/zksync-era#3556)) ([d39fb6d](matter-labs/zksync-era@d39fb6d)) * **vm:** Fix VM divergences related to validation ([#3567](matter-labs/zksync-era#3567)) ([170d194](matter-labs/zksync-era@170d194)) ### Performance Improvements * **db:** Remove `events.tx_initiator_address` writes and index ([#3559](matter-labs/zksync-era#3559)) ([298abd2](matter-labs/zksync-era@298abd2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>

slowli added 12 commits January 8, 2025 15:26

Remove setting contract_address in DAL query

7cc5b59

Add more address derivation logic for deployments

338433a

Sketch new contract_address logic in API server

9f9d219

Test create2 address derivation for EraVM contracts

8c83c71

Refactor test utils to prepare for testing contract_address

63f510a

Refactor test utils some more

0b750a1

Fix / test fill_transaction_receipts()

0186588

Use dedicated query for contract deployment events

d86025a

Sketch test permissive account contract

04bdb02

Test permissive account in API server

026957b

Better structure fill_transaction_receipts()

7a3ccd3

Fix (?) transaction receipt test

1fceeb5

slowli commented Jan 10, 2025

View reviewed changes

slowli marked this pull request as ready for review January 10, 2025 13:32

slowli requested review from 0xVolosnikov, itegulov, perekopskiy and popzxc January 10, 2025 13:33

slowli added 3 commits January 14, 2025 12:09

Update from upstream

f0e78f1

Update from upstream

83d555b

Revert bogus lockfile update

72034db

perekopskiy previously approved these changes Jan 28, 2025

View reviewed changes

core/lib/dal/src/models/storage_transaction.rs Outdated Show resolved Hide resolved

slowli added 2 commits February 4, 2025 22:58

Do not set contract_address for custom AAs

2291c26

Update from upstream

865dda2

slowli dismissed perekopskiy’s stale review via 865dda2 February 5, 2025 09:00

Remove resolved FIXME

d205edd

0xVolosnikov approved these changes Feb 5, 2025

View reviewed changes

slowli added this pull request to the merge queue Feb 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025

slowli added this pull request to the merge queue Feb 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025

slowli added this pull request to the merge queue Feb 6, 2025

Merged via the queue into main with commit 4179711 Feb 6, 2025
33 checks passed

slowli deleted the aov-evm-923-transaction-receipt-should-include-contractaddress-only-if branch February 6, 2025 16:51

zksync-era-bot mentioned this pull request Feb 6, 2025

chore(main): release core 26.3.0 #3544

Merged

MexicanAce mentioned this pull request Feb 13, 2025

fix: parse newly created account address from events matter-labs/zksync-sso#66

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(api): Change `contractAddress` assignment for transaction receipts #3452

fix(api): Change `contractAddress` assignment for transaction receipts #3452

Uh oh!

slowli commented Jan 10, 2025

Uh oh!

slowli left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perekopskiy left a comment

Uh oh!

Uh oh!

slowli commented Feb 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(api): Change contractAddress assignment for transaction receipts #3452

fix(api): Change contractAddress assignment for transaction receipts #3452

Uh oh!

Conversation

slowli commented Jan 10, 2025

What ❔

Why ❔

Checklist

Uh oh!

slowli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perekopskiy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

slowli commented Feb 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(api): Change `contractAddress` assignment for transaction receipts #3452

fix(api): Change `contractAddress` assignment for transaction receipts #3452