refactor: move Cargo.toml from root to core workspace #3456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbaliasnikov
force-pushed
the
aba-move-cargo-to-core
branch
3 times, most recently
from
97ee4b6 to
a5161b3
Compare
antonbaliasnikov
requested review from
alexandrst88,
artmakh,
hatemosphere,
iluwaa,
onyxet,
otani88,
popzxc and
yorik
antonbaliasnikov
force-pushed
the
aba-move-cargo-to-core
branch
2 times, most recently
from
2ab2a68 to
b4926e6
Compare
Contributor
Author
|
@popzxc , can you, please, merge when it's ok? It looks like I'm not authorized to merge here. |
Member
|
@antonbaliasnikov looks like there is a merge conflict now 🥲 |
antonbaliasnikov
force-pushed
the
aba-move-cargo-to-core
branch
from
b4926e6 to
caccdf4
Compare
Contributor
Author
@popzxc , rebased my changes and fixed a bug in |
popzxc
approved these changes
Jan 16, 2025
artmakh
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ Move `Cargo.toml` from repository root to `core` workspace. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ It is mandatory for proper separation of workspaces and setting up a `release-please` CI that requires all files of a component to be inside the component directory. ## CI failures Currently, the following tests are failing: * `protobuf_compatibility` - the workflow is using base version and will be fixed with the next PRs after merge to `main`. <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Move
Cargo.tomlfrom repository root tocoreworkspace.Why ❔
It is mandatory for proper separation of workspaces and setting up a
release-pleaseCI that requires all files of a component to be inside the component directory.CI failures
Currently, the following tests are failing:
protobuf_compatibility- the workflow is using base version and will be fixed with the next PRs after merge tomain.Checklist
zkstack dev fmtandzkstack dev lint.