Skip to content

Conversation

@koloz193
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@koloz193 koloz193 requested a review from a team as a code owner January 13, 2025 15:36
@koloz193 koloz193 requested review from zksync-admin-bot2 and removed request for a team January 13, 2025 15:36
@github-actions
Copy link
Contributor

⚠ Detected differing instruction counts

Benchmark Old count New count
access_memory 4748223 4748374
call_far 319709 319525
decode_shl_sub 4748317 4748479
deploy_simple_contract 15638 15422
event_spam 2581783 2558512
finish_eventful_frames 786191 786039
heap_read_write 4252711 4252844
slot_hash_collision 4749237 4749388
write_and_decode 4749237 4749388

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it to run out of gas at a different time.

@StanislavBreadless StanislavBreadless merged commit 947fa76 into sync-layer-stable Jan 14, 2025
40 of 45 checks passed
@StanislavBreadless StanislavBreadless deleted the zk-sl-compiler-bump branch January 14, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants