feat: Compressor optimizations #3476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # etc/env/base/contracts.toml
Artemka374
requested review from
alexandrst88,
artmakh,
hatemosphere,
iluwaa,
onyxet,
otani88 and
yorik
…o/faster-compressor (#3485) "Update generated Prover FRI GPU setup-data keys from branch afo/faster-compressor"
# Conflicts: # Cargo.toml
…o/faster-compressor (#3496) "Update generated Prover FRI GPU setup-data keys from branch afo/faster-compressor" --------- Co-authored-by: Lech <[email protected]>
EmilLuta
reviewed
Jan 20, 2025
Contributor
EmilLuta
left a comment
EmilLuta
left a comment
There was a problem hiding this comment.
Maybe I'm missing something, but given we're changing all the keys, isn't this a "protocol upgrade"?
Contributor
Author
|
Regarding the protocol upgrade - no, the keys are actually not changed, the only thing changed there is the format of them |
EmilLuta
changed the title
Contributor
|
Note: CRS & Keys are being changed, therefore we mark this PR as breaking. |
EmilLuta
previously approved these changes
Jan 23, 2025
Artemka374
changed the title
iluwaa
approved these changes
Jan 23, 2025
This was referenced Jan 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
🤖 I have created a release *beep* *boop* --- ## [26.2.0](core-v26.1.0...core-v26.2.0) (2025-01-24) ### Features * Compressor optimizations ([#3476](#3476)) ([3e931be](3e931be)) ### Bug Fixes * **en:** better defaults, i.e. the same as used by main node ([#3521](#3521)) ([2b5fe98](2b5fe98)) * **en:** Fix race condition in EN storage initialization ([#3515](#3515)) ([c916797](c916797)) * JSON proof serialization ([#3514](#3514)) ([516e521](516e521)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Anton Baliasnikov <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
🤖 I have created a release *beep* *boop* --- ## [18.0.0](prover-v17.1.1...prover-v18.0.0) (2025-01-27) ### ⚠ BREAKING CHANGES * **contracts:** gateway integration ([#1934](#1934)) ### Features * Compressor optimizations ([#3476](#3476)) ([3e931be](3e931be)) * **consensus:** Added view_timeout to consensus config ([#3383](#3383)) ([fc02a8f](fc02a8f)) * **consensus:** Update consensus dependencies ([#3339](#3339)) ([aa9575f](aa9575f)) * **contracts:** gateway integration ([#1934](#1934)) ([f06cb79](f06cb79)) * **eth-watch:** Change protocol upgrade schema ([#3435](#3435)) ([2c778fd](2c778fd)) * FFLONK support for compressor ([#3359](#3359)) ([1a297be](1a297be)) * Support stable compiler for VM (and some other crates) ([#3248](#3248)) ([cbee99d](cbee99d)) ### Bug Fixes * added missing quote in prover query ([#3347](#3347)) ([668ca51](668ca51)) * Compressor setup data ([#3526](#3526)) ([62aea8b](62aea8b)) * **prover:** Create reqwest client only once ([#3324](#3324)) ([40f8123](40f8123)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
## What ❔ Integrate optimizations for compressor's work. Before: PLONK: ~180s FFLONK: ~248s Now Both: ~70s ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: afo <[email protected]> Co-authored-by: zksync-admin-bot2 <[email protected]>
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
🤖 I have created a release *beep* *boop* --- ## [26.2.0](core-v26.1.0...core-v26.2.0) (2025-01-24) ### Features * Compressor optimizations ([#3476](#3476)) ([8c647f5](8c647f5)) ### Bug Fixes * **en:** better defaults, i.e. the same as used by main node ([#3521](#3521)) ([2b5fe98](2b5fe98)) * **en:** Fix race condition in EN storage initialization ([#3515](#3515)) ([c916797](c916797)) * JSON proof serialization ([#3514](#3514)) ([516e521](516e521)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Anton Baliasnikov <[email protected]>
dutterbutter
pushed a commit
to dutterbutter/zkstack-cli
that referenced
this pull request
Jul 3, 2025
🤖 I have created a release *beep* *boop* --- ## [26.2.0](matter-labs/zksync-era@core-v26.1.0...core-v26.2.0) (2025-01-24) ### Features * Compressor optimizations ([#3476](matter-labs/zksync-era#3476)) ([bf7b62b](matter-labs/zksync-era@bf7b62b)) ### Bug Fixes * **en:** better defaults, i.e. the same as used by main node ([#3521](matter-labs/zksync-era#3521)) ([2b5fe98](matter-labs/zksync-era@2b5fe98)) * **en:** Fix race condition in EN storage initialization ([#3515](matter-labs/zksync-era#3515)) ([c916797](matter-labs/zksync-era@c916797)) * JSON proof serialization ([#3514](matter-labs/zksync-era#3514)) ([516e521](matter-labs/zksync-era@516e521)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Anton Baliasnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Integrate optimizations for compressor's work.
Before:
PLONK: ~180s
FFLONK: ~248s
Now
Both: ~70s
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.