Skip to content

feat: zkos integration tests #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
perekopskiy wants to merge 15 commits into from
Closed

feat: zkos integration tests #3497

perekopskiy wants to merge 15 commits into from

Conversation

@perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Jan 17, 2025 •
edited
Loading

What ❔

  • use nonce from storage (by Roman)
  • save error to DB for reverted txs
  • correctly reject txs in state keeper
  • adjust some tests from ether.test.ts and contracts.test.ts so they work

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@perekopskiy perekopskiy requested a review from a team as a code owner January 17, 2025 14:07
@perekopskiy perekopskiy requested review from alexandrst88, artmakh, hatemosphere, iluwaa, onyxet, otani88 and yorik and removed request for a team January 17, 2025 14:07
@perekopskiy perekopskiy changed the title Mp zkos int tests feat: zkos integration tests Jan 17, 2025
@perekopskiy perekopskiy deleted the mp-zkos-int-tests branch April 24, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@perekopskiy @AntonD3 @RomanBrodetski