Skip to content

Conversation

@tahsintunan
Copy link
Contributor

Description

This PR resolves the build failure in zksync_prover_job_processor caused by the following error:

error[E0432]: unresolved import tokio::task::JoinHandle
   --> crates/lib/prover_job_processor/src/job_runner.rs:1:5
    |
1   | use tokio::task::JoinHandle;
    |     ^^^^^^^^^^^^^^^^^^^^^^^ no JoinHandle in task

The error occurred because JoinHandle was gated behind the rt feature in Tokio, which was disabled. Enabling the feature resolves the import and fixes the build.

@tahsintunan
Copy link
Contributor Author

Pinging @EmilLuta (can't add you as a reviewer)

@EmilLuta EmilLuta changed the title Fix JoinHandle import issue by enabling 'rt' feature in Tokio chore: JoinHandle import issue by enabling 'rt' feature in Tokio Jan 20, 2025
@EmilLuta EmilLuta changed the title chore: JoinHandle import issue by enabling 'rt' feature in Tokio chore: Localize feature import to crate for circuit prover Jan 20, 2025
@tahsintunan tahsintunan requested a review from EmilLuta January 20, 2025 14:17
@EmilLuta EmilLuta added this pull request to the merge queue Jan 20, 2025
Merged via the queue into matter-labs:main with commit b7618e1 Jan 20, 2025
31 checks passed
@tahsintunan tahsintunan deleted the fix/tokio-joinhandle-import branch January 20, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants