Skip to content

Conversation

@itegulov
Copy link
Contributor

What ❔

A bunch of small improvements to make fee tests robust:

  • Upgrade ethers
  • Catch retryable networking issues in ethers.FetchRequest
  • Destroy providers on context teardown to avoid econnreset
  • Retry fee-related issues that can arise when transaction is rejected by mempool

Why ❔

Fee tests are disruptively flaky right now

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@itegulov itegulov force-pushed the daniyar/fix-fee-tests-econnreset branch 2 times, most recently from 31dc69c to 20b4256 Compare January 20, 2025 07:26
@itegulov itegulov force-pushed the daniyar/fix-fee-tests-econnreset branch from b0425b7 to da4dd2f Compare January 20, 2025 08:20
@itegulov itegulov marked this pull request as ready for review January 20, 2025 10:01
@itegulov
Copy link
Contributor Author

Verified that this PR passes fee tests 10 times in a row (job). Revert tests failed but its for an unrelated reason (its flaky when batch execution is behind, as happens when fee tests are ran 10 times in a quick succession).

@itegulov itegulov enabled auto-merge January 20, 2025 10:04
@itegulov itegulov added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 6a0c1a6 Jan 20, 2025
34 checks passed
@itegulov itegulov deleted the daniyar/fix-fee-tests-econnreset branch January 20, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants