refactor(zk_toolbox): Minimize zkstack dependency on zksync_config (pt. 2)
#3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it cannot be removed completely because gateway scripts depend on it.
Deniallugo
previously approved these changes
Mar 6, 2025
slowli
force-pushed
the
aov-pla-1078-minimize-zkstack-dependency-on-zksync_config-pt2
branch
from
ef11c76 to
9b56b37
Compare
Deniallugo
previously approved these changes
Apr 9, 2025
Deniallugo
reviewed
Apr 9, 2025
Deniallugo
previously approved these changes
Apr 14, 2025
Deniallugo
previously approved these changes
Apr 14, 2025
artmakh
approved these changes
Apr 14, 2025
slowli
deleted the
aov-pla-1078-minimize-zkstack-dependency-on-zksync_config-pt2
branch
zkzoomer
pushed a commit
that referenced
this pull request
Jun 21, 2025
…(pt. 2) (#3543) ## What ❔ - Completely removes `zksync_*config` deps in zkstack. - Introduces strongly-typed wrappers for configs in zkstack. ## Why ❔ Part of preparations for integrating a new config system. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
zksync_*configdeps in zkstack.Why ❔
Part of preparations for integrating a new config system.
Checklist
zkstack dev fmtandzkstack dev lint.