Skip to content

feat(vm): Support missed storage invocation limit in fast VM #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joonazan merged 7 commits into from
Feb 10, 2025
Merged

feat(vm): Support missed storage invocation limit in fast VM #3548

joonazan merged 7 commits into from
Feb 10, 2025

Conversation

@slowli
Copy link
Contributor

@slowli slowli commented Jan 29, 2025

What ❔

Supports the missed storage invocation limit in the fast VM.

Why ❔

This is a missing piece of functionality to bring the fast VM on par with the legacy one.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

slowli
slowli commented Jan 29, 2025
View reviewed changes
@slowli slowli marked this pull request as ready for review January 29, 2025 14:54
joonazan
joonazan reviewed Jan 29, 2025
View reviewed changes
@slowli slowli requested a review from joonazan February 5, 2025 10:23
joonazan
joonazan previously approved these changes Feb 7, 2025
View reviewed changes
@joonazan joonazan added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@joonazan joonazan added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
perekopskiy
perekopskiy previously approved these changes Feb 10, 2025
View reviewed changes
@slowli slowli added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@slowli slowli dismissed stale reviews from perekopskiy and joonazan via dd4c37e February 10, 2025 12:55
@joonazan joonazan added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit ef67694 Feb 10, 2025
33 checks passed
@joonazan joonazan deleted the aov-pla-1085-support-missed_storage_invocation_limit branch February 10, 2025 14:55
@zksync-era-bot zksync-era-bot mentioned this pull request Feb 10, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2025
@zksync-era-bot
chore(main): release core 26.3.0 (#3544)
0c998e2 
🤖 I have created a release *beep* *boop*
---


##
[26.3.0](core-v26.2.1...core-v26.3.0)
(2025-02-12)


### Features

* **contract-verifier:** Do not allow verification requests for verified
contracts
([#3578](#3578))
([6a1f1b8](6a1f1b8))
* **contract-verifier:** Partial matching & automatic verification
([#3527](#3527))
([bf9fe85](bf9fe85))
* **contract-verifier:** Support missing options for EVM in API
([#3592](#3592))
([309fdf4](309fdf4))
* **en:** better EN default req entities limit, improved documentation
for API limits
([#3546](#3546))
([e7eb716](e7eb716))
* make `zksync_types` thinner
([#3574](#3574))
([e7f93e4](e7f93e4))
* new da_dispatcher metrics
([#3464](#3464))
([75a7c08](75a7c08))
* update FFLONK protocol version
([#3572](#3572))
([a352852](a352852))
* **vm:** Allow caching signature verification
([#3505](#3505))
([7bb5ed3](7bb5ed3))
* **vm:** Support missed storage invocation limit in fast VM
([#3548](#3548))
([ef67694](ef67694))


### Bug Fixes

* Add debug information to object store retries
([#3576](#3576))
([036315c](036315c))
* allow configuring NoDA client via ENV
([#3599](#3599))
([a72ab63](a72ab63))
* **api:** Change `contractAddress` assignment for transaction receipts
([#3452](#3452))
([4179711](4179711))
* **api:** Improve estimation for gas_per_pubdata_limit
([#3475](#3475))
([bda1b25](bda1b25))
* Avail gas relay decoding issues
([#3547](#3547))
([a171433](a171433))
* **ci:** commenting out getFilterChanges test until fix is ready
([#3582](#3582))
([99c3905](99c3905))
* Support newer versions of foundry-zksync
([#3556](#3556))
([d39fb6d](d39fb6d))
* **vm:** Fix VM divergences related to validation
([#3567](#3567))
([170d194](170d194))


### Performance Improvements

* **db:** Remove `events.tx_initiator_address` writes and index
([#3559](#3559))
([298abd2](298abd2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
zkzoomer pushed a commit that referenced this pull request Jun 21, 2025
@zksync-era-bot
chore(main): release core 26.3.0 (#3544)
da6e701 
🤖 I have created a release *beep* *boop*
---


##
[26.3.0](core-v26.2.1...core-v26.3.0)
(2025-02-12)


### Features

* **contract-verifier:** Do not allow verification requests for verified
contracts
([#3578](#3578))
([6a1f1b8](6a1f1b8))
* **contract-verifier:** Partial matching & automatic verification
([#3527](#3527))
([b94d1ad](b94d1ad))
* **contract-verifier:** Support missing options for EVM in API
([#3592](#3592))
([309fdf4](309fdf4))
* **en:** better EN default req entities limit, improved documentation
for API limits
([#3546](#3546))
([e7eb716](e7eb716))
* make `zksync_types` thinner
([#3574](#3574))
([292e731](292e731))
* new da_dispatcher metrics
([#3464](#3464))
([75a7c08](75a7c08))
* update FFLONK protocol version
([#3572](#3572))
([a352852](a352852))
* **vm:** Allow caching signature verification
([#3505](#3505))
([7bb5ed3](7bb5ed3))
* **vm:** Support missed storage invocation limit in fast VM
([#3548](#3548))
([ef67694](ef67694))


### Bug Fixes

* Add debug information to object store retries
([#3576](#3576))
([036315c](036315c))
* allow configuring NoDA client via ENV
([#3599](#3599))
([a72ab63](a72ab63))
* **api:** Change `contractAddress` assignment for transaction receipts
([#3452](#3452))
([4179711](4179711))
* **api:** Improve estimation for gas_per_pubdata_limit
([#3475](#3475))
([bda1b25](bda1b25))
* Avail gas relay decoding issues
([#3547](#3547))
([a171433](a171433))
* **ci:** commenting out getFilterChanges test until fix is ready
([#3582](#3582))
([99c3905](99c3905))
* Support newer versions of foundry-zksync
([#3556](#3556))
([d39fb6d](d39fb6d))
* **vm:** Fix VM divergences related to validation
([#3567](#3567))
([170d194](170d194))


### Performance Improvements

* **db:** Remove `events.tx_initiator_address` writes and index
([#3559](#3559))
([298abd2](298abd2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
dutterbutter pushed a commit to dutterbutter/zkstack-cli that referenced this pull request Jul 3, 2025
@zksync-era-bot
chore(main): release core 26.3.0 (#3544)
a8031f5 
🤖 I have created a release *beep* *boop*
---


##
[26.3.0](matter-labs/zksync-era@core-v26.2.1...core-v26.3.0)
(2025-02-12)


### Features

* **contract-verifier:** Do not allow verification requests for verified
contracts
([#3578](matter-labs/zksync-era#3578))
([6a1f1b8](matter-labs/zksync-era@6a1f1b8))
* **contract-verifier:** Partial matching & automatic verification
([#3527](matter-labs/zksync-era#3527))
([a0b7ca1](matter-labs/zksync-era@a0b7ca1))
* **contract-verifier:** Support missing options for EVM in API
([#3592](matter-labs/zksync-era#3592))
([309fdf4](matter-labs/zksync-era@309fdf4))
* **en:** better EN default req entities limit, improved documentation
for API limits
([#3546](matter-labs/zksync-era#3546))
([e7eb716](matter-labs/zksync-era@e7eb716))
* make `zksync_types` thinner
([#3574](matter-labs/zksync-era#3574))
([fc84832](matter-labs/zksync-era@fc84832))
* new da_dispatcher metrics
([#3464](matter-labs/zksync-era#3464))
([75a7c08](matter-labs/zksync-era@75a7c08))
* update FFLONK protocol version
([#3572](matter-labs/zksync-era#3572))
([a352852](matter-labs/zksync-era@a352852))
* **vm:** Allow caching signature verification
([#3505](matter-labs/zksync-era#3505))
([7bb5ed3](matter-labs/zksync-era@7bb5ed3))
* **vm:** Support missed storage invocation limit in fast VM
([#3548](matter-labs/zksync-era#3548))
([ef67694](matter-labs/zksync-era@ef67694))


### Bug Fixes

* Add debug information to object store retries
([#3576](matter-labs/zksync-era#3576))
([036315c](matter-labs/zksync-era@036315c))
* allow configuring NoDA client via ENV
([#3599](matter-labs/zksync-era#3599))
([a72ab63](matter-labs/zksync-era@a72ab63))
* **api:** Change `contractAddress` assignment for transaction receipts
([#3452](matter-labs/zksync-era#3452))
([4179711](matter-labs/zksync-era@4179711))
* **api:** Improve estimation for gas_per_pubdata_limit
([#3475](matter-labs/zksync-era#3475))
([bda1b25](matter-labs/zksync-era@bda1b25))
* Avail gas relay decoding issues
([#3547](matter-labs/zksync-era#3547))
([a171433](matter-labs/zksync-era@a171433))
* **ci:** commenting out getFilterChanges test until fix is ready
([#3582](matter-labs/zksync-era#3582))
([99c3905](matter-labs/zksync-era@99c3905))
* Support newer versions of foundry-zksync
([#3556](matter-labs/zksync-era#3556))
([d39fb6d](matter-labs/zksync-era@d39fb6d))
* **vm:** Fix VM divergences related to validation
([#3567](matter-labs/zksync-era#3567))
([170d194](matter-labs/zksync-era@170d194))


### Performance Improvements

* **db:** Remove `events.tx_initiator_address` writes and index
([#3559](matter-labs/zksync-era#3559))
([298abd2](matter-labs/zksync-era@298abd2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perekopskiy perekopskiy perekopskiy left review comments

+1 more reviewer

@joonazan joonazan joonazan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slowli @joonazan @perekopskiy