feat: EN commit, prove, execute batch transactions verification and finality status #4080
+2,702
−282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
reviewed
May 27, 2025
Deniallugo
reviewed
May 27, 2025
This updater is used in ENs and should not add transaction to database without first verifying their validity.
cytadela8
force-pushed
the
apu-fast-finality-l2
branch
from
037f0cf to
d0ff485
Compare
cytadela8
changed the title
cytadela8
changed the title
cytadela8
force-pushed
the
apu-fast-finality-l2
branch
from
d0ff485 to
1bd4e0e
Compare
cytadela8
force-pushed
the
apu-fast-finality-l2
branch
from
1bd4e0e to
562eee9
Compare
Deniallugo
reviewed
May 29, 2025
slowli
reviewed
Jun 24, 2025
Contributor
slowli
left a comment
slowli
left a comment
There was a problem hiding this comment.
Sorry for the delayed review. Looks substantially better; most comments are nits (but IMO, would be easy to resolve).
Deniallugo
reviewed
Jun 27, 2025
core/node/node_sync/src/batch_transaction_updater/l1_transaction_verifier.rs
Outdated
Show resolved
Hide resolved
Deniallugo
approved these changes
Jul 1, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
🤖 I have created a release *beep* *boop* --- ## [28.8.0](core-v28.7.0...core-v28.8.0) (2025-07-07) ### Features * **ci:** fast integration tests framework ([#4255](#4255)) ([a72cbd8](a72cbd8)) * **eigenda:** EigenDA V2 M0 ([#3983](#3983)) ([8302a81](8302a81)) * EN commit, prove, execute batch transactions verification and finality status ([#4080](#4080)) ([d06697d](d06697d)) * **en:** remove JSON RPC syncing ([#4258](#4258)) ([d194604](d194604)) * **state-keeper:** implement block commit/rollback ([#4197](#4197)) ([99af8fc](99af8fc)) * **zkstack:** fast fmt ([#4222](#4222)) ([d05c3dd](d05c3dd)) ### Bug Fixes * **consensus:** Debug page server port reuse ([#4273](#4273)) ([77d043f](77d043f)) * **eth-watch:** return internal errors from BatchRootProcessor ([#4285](#4285)) ([1f668e5](1f668e5)) * use FullPubdataBuilder for all pre-gateway batches ([#4265](#4265)) ([7c46480](7c46480)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
jishnundth
pushed a commit
to jishnundth/zksync-era
that referenced
this pull request
Oct 6, 2025
…inality status (matter-labs#4080) ## What ❔ - Added validation against SL of commit prove and execute transaction hashes provided by main node to ENs in `BatchStatusUpdater`. - Properly update transaction finalization status on EN. Marking as Pending when fetches and updated to fast finalized and finalized when reaching those statuses. ## Why ❔ Database is our source of truth used by e.g. API to provide clients with information about chain state. EN should not trust main node about the provided finalization status of batches. EN should verify claims about status changes of batches with L1. This is done here instead of consistency checker, as the consistency checker validates post factum. We also validate the logs from receipts in transactions, making sure commit/prove/exeucte transactions actually perform what the should. ## Is this a breaking change? - [ ] Yes - [x] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
jishnundth
pushed a commit
to jishnundth/zksync-era
that referenced
this pull request
Oct 6, 2025
🤖 I have created a release *beep* *boop* --- ## [28.8.0](matter-labs/zksync-era@core-v28.7.0...core-v28.8.0) (2025-07-07) ### Features * **ci:** fast integration tests framework ([matter-labs#4255](matter-labs#4255)) ([a72cbd8](matter-labs@a72cbd8)) * **eigenda:** EigenDA V2 M0 ([matter-labs#3983](matter-labs#3983)) ([8302a81](matter-labs@8302a81)) * EN commit, prove, execute batch transactions verification and finality status ([matter-labs#4080](matter-labs#4080)) ([d06697d](matter-labs@d06697d)) * **en:** remove JSON RPC syncing ([matter-labs#4258](matter-labs#4258)) ([d194604](matter-labs@d194604)) * **state-keeper:** implement block commit/rollback ([matter-labs#4197](matter-labs#4197)) ([99af8fc](matter-labs@99af8fc)) * **zkstack:** fast fmt ([matter-labs#4222](matter-labs#4222)) ([d05c3dd](matter-labs@d05c3dd)) ### Bug Fixes * **consensus:** Debug page server port reuse ([matter-labs#4273](matter-labs#4273)) ([77d043f](matter-labs@77d043f)) * **eth-watch:** return internal errors from BatchRootProcessor ([matter-labs#4285](matter-labs#4285)) ([1f668e5](matter-labs@1f668e5)) * use FullPubdataBuilder for all pre-gateway batches ([matter-labs#4265](matter-labs#4265)) ([7c46480](matter-labs@7c46480)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
BatchStatusUpdater.Why ❔
Database is our source of truth used by e.g. API to provide clients with information about chain state. EN should not trust main node about the provided finalization status of batches. EN should verify claims about status changes of batches with L1. This is done here instead of consistency checker, as the consistency checker validates post factum.
We also validate the logs from receipts in transactions, making sure commit/prove/exeucte transactions actually perform what the should.
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.