release zksync os #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Deniallugo merged 23 commits into zksync-os-integration from deniallugo-release-zksync-os

Jun 24, 2025

Contributor

Deniallugo commented Jun 19, 2025 •

edited

Loading

What ❔

Release zksync os prover and server. For using it later in demo stands.

Why ❔

Is this a breaking change?

Yes
No

Operational changes

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zkstack dev fmt and zkstack dev lint.

Deniallugo changed the base branch from main to zksync-os-integration

June 19, 2025 14:52

Contributor

github-actions bot commented Jun 19, 2025 •

edited

Loading

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

feat(eth_sender): Support new transaction type
fix(state_keeper): Correctly handle edge case
ci: Add new workflow for linting

Details:

No release type found in pull request title "release zksync os". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/release-zkos-stage.yml

Comment on lines 13 to 42

+                  runs-on: ubuntu-latest
+                  name: Test changed-files
+                  outputs:
+                    core: ${{ steps.changed-files-yaml.outputs.core_any_changed }}
+                    prover: ${{ steps.changed-files-yaml.outputs.prover_any_changed }}
+                    all: ${{ steps.changed-files-yaml.outputs.all_any_changed }}
+                  steps:
+                    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+                      with:
+                        fetch-depth: 2
+                    - name: Get all test, doc and src files that have changed
+                      id: changed-files-yaml
+                      uses: tj-actions/changed-files@48566bbcc22ceb7c5809ebdd27377309f2c3de8c # v39
+                      with:
+                        files_yaml: |
+                          # TODO: make it more granular, as already implemented in CI workflow
+                          # We don't want to be rebuilding and redeploying all the Docker images when eg. only document have changed
+                          prover:
+                            - prover/**
+                            - core/lib/**
+                            - zkos_prover/**
+                            - '!core/lib/zksync_core_leftovers/**'
+                          core:
+                            - core/**
+                          all:
+                            - '!core/**'
+                            - '!prover/**'
+                setup:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}

.github/workflows/release-zkos-stage.yml

Comment on lines 24 to 42

+                    - name: Get all test, doc and src files that have changed
+                      id: changed-files-yaml
+                      uses: tj-actions/changed-files@48566bbcc22ceb7c5809ebdd27377309f2c3de8c # v39
+                      with:
+                        files_yaml: |
+                          # TODO: make it more granular, as already implemented in CI workflow
+                          # We don't want to be rebuilding and redeploying all the Docker images when eg. only document have changed
+                          prover:
+                            - prover/**
+                            - core/lib/**
+                            - zkos_prover/**
+                            - '!core/lib/zksync_core_leftovers/**'
+                          core:
+                            - core/**
+                          all:
+                            - '!core/**'
+                            - '!prover/**'
+                setup:

Check failure

Code scanning / CodeQL

Use of a known vulnerable action

The workflow is using a known vulnerable version ([48566bbcc22ceb7c5809ebdd27377309f2c3de8c](1)) of the [tj-actions/changed-files](2) action. Update it to [41](3)

.github/workflows/release-zkos-stage.yml

Comment on lines 42 to 63

+                  name: Setup
+                  runs-on: [ matterlabs-deployer-stage ]
+                  outputs:
+                    image_tag_suffix: ${{ steps.generate-tag-suffix.outputs.image_tag_suffix }}
+                    prover_fri_gpu_key_id: ${{ steps.extract-prover-fri-setup-key-ids.outputs.gpu_short_commit_sha }}
+                  steps:
+                    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+                    - name: Generate image tag suffix
+                      id: generate-tag-suffix
+                      run: |
+                        sha=$(git rev-parse --short HEAD)
+                        ts=$(date +%s%N | cut -b1-13)
+                        echo "image_tag_suffix=${sha}-${ts}" >> $GITHUB_OUTPUT
+                    - name: Generate outputs with Prover FRI setup data keys IDs
+                      id: extract-prover-fri-setup-key-ids
+                      run: |
+                        ./prover/extract-setup-data-keys.sh >> $GITHUB_OUTPUT
+                build-push-core-images:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}

.github/workflows/release-zkos-stage.yml

Comment on lines 63 to 76

+                  name: Build and push images
+                  needs: [ setup, changed_files ]
+                  uses: ./.github/workflows/build-core-template.yml
+                  if: needs.changed_files.outputs.core == 'true' || needs.changed_files.outputs.all == 'true'
+                  with:
+                    image_tag_suffix: ${{ needs.setup.outputs.image_tag_suffix }}
+                    action: "build"
+                  secrets:
+                    DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
+                    DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
+                build-push-prover-images:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}

.github/workflows/release-zkos-stage.yml

Comment on lines 76 to 87

+                  name: Build and push images
+                  needs: [ setup, changed_files ]
+                  uses: ./.github/workflows/build-zksyncos-prover-template.yml
+                  if: needs.changed_files.outputs.prover == 'true' || needs.changed_files.outputs.all == 'true'
+                  with:
+                    image_tag_suffix: ${{ needs.setup.outputs.image_tag_suffix }}
+                    ERA_BELLMAN_CUDA_RELEASE: ${{ vars.ERA_BELLMAN_CUDA_RELEASE }}
+                    action: "build"
+                  secrets:
+                    DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
+                    DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}

Deniallugo force-pushed the deniallugo-release-zksync-os branch from fbbcad0 to b007d1e Compare

June 19, 2025 16:02

Deniallugo added 6 commits

June 20, 2025 10:33


          Relase zksync os prover

14164e8

Signed-off-by: Danil <[email protected]>


          change push to build

90bdb30

Signed-off-by: Danil <[email protected]>


          start testing

a585c60

Signed-off-by: Danil <[email protected]>


          remove prover from docker ignore

b9778db

Signed-off-by: Danil <[email protected]>


          Update cmake

08eaf6c

Signed-off-by: Danil <[email protected]>


          Fix container

ba77cdb

Signed-off-by: Danil <[email protected]>

Deniallugo force-pushed the deniallugo-release-zksync-os branch from e74cc9c to ba77cdb Compare

June 20, 2025 08:33

Deniallugo added 4 commits

June 20, 2025 11:10


          Remove hack

5b4f688

Signed-off-by: Danil <[email protected]>


          Remove gpu flag

Signed-off-by: Danil <[email protected]>


          fix docker

e9409b9

Signed-off-by: Danil <[email protected]>


          Set zksync os flag

d767281

Signed-off-by: Danil <[email protected]>

Deniallugo force-pushed the deniallugo-release-zksync-os branch from 83287c0 to d767281 Compare

June 20, 2025 10:48

Deniallugo added 3 commits

June 20, 2025 13:06


          Fix tag

59ab5f6

Signed-off-by: Danil <[email protected]>


          Add latest to the push

a997fa4

Signed-off-by: Danil <[email protected]>


          Update names

0ad3d66

Signed-off-by: Danil <[email protected]>

artmakh approved these changes

View reviewed changes


          change build to push

82e5691

Signed-off-by: Danil <[email protected]>

Deniallugo force-pushed the deniallugo-release-zksync-os branch 2 times, most recently from 9452136 to ac2a555 Compare

June 23, 2025 14:07


          change build to push

5ddeea8

Signed-off-by: Danil <[email protected]>

Deniallugo force-pushed the deniallugo-release-zksync-os branch from ac2a555 to 5ddeea8 Compare

June 23, 2025 14:45

Deniallugo added 2 commits

June 23, 2025 17:23


          fix docker ignore

f9210a6

Signed-off-by: Danil <[email protected]>


          copy app.bin

75e2861

Signed-off-by: Danil <[email protected]>

Deniallugo force-pushed the deniallugo-release-zksync-os branch from 44a749f to 75e2861 Compare

June 23, 2025 16:36

Deniallugo added 2 commits

June 23, 2025 18:37


          Remove cuda

4ca075e

Signed-off-by: Danil <[email protected]>

fix

1734b22

Signed-off-by: Danil <[email protected]>

Deniallugo force-pushed the deniallugo-release-zksync-os branch from 56b6cc2 to 1734b22 Compare

June 23, 2025 17:07

Deniallugo added 2 commits

June 24, 2025 11:04


          remove branch

96d10df

Signed-off-by: Danil <[email protected]>


          remove ns

40a2102

Signed-off-by: Danil <[email protected]>

yorik reviewed

View reviewed changes

.dockerignore Show resolved Hide resolved

.github/workflows/release-zkos-stage.yml Outdated Show resolved Hide resolved

docker/zksync-os-prover/Dockerfile Outdated Show resolved Hide resolved

docker/zksync-os-server/Dockerfile Outdated Show resolved Hide resolved

Deniallugo added 2 commits

June 24, 2025 12:36


          fix review comments

7b91b4e

Signed-off-by: Danil <[email protected]>


          remove current branch

c9b409a

Signed-off-by: Danil <[email protected]>

Deniallugo marked this pull request as ready for review

June 24, 2025 11:38

Deniallugo requested a review from a team as a code owner

June 24, 2025 11:38

Deniallugo requested review from alexandrst88, hatemosphere, iluwaa, onyxet, otani88 and yorik and removed request for a team

June 24, 2025 11:38

Deniallugo merged commit 14fc751 into zksync-os-integration

7 of 15 checks passed

Deniallugo deleted the deniallugo-release-zksync-os branch

June 24, 2025 11:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

artmakh artmakh approved these changes

yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Labels

None yet