chore(zkstack): Use trait for zkstack config #4449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Deniallugo
force-pushed
the
deniallugo-rename-config-trait
branch
2 times, most recently
from
c05eba9 to
676fa1f
Compare
Signed-off-by: Danil <[email protected]>
Deniallugo
force-pushed
the
deniallugo-rename-config-trait
branch
from
676fa1f to
63b191b
Compare
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Deniallugo
changed the title
mm-zk
approved these changes
Sep 3, 2025
zkstack_cli/crates/zkstack/src/commands/dev/commands/init_test_wallet.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Before for chain/ecosystem trait we had only
link_to_codeand all other path has been calculated from this link.Now it's a trait, that allows to implement custom paths for
link_to_code,contracts,configsWhy ❔
For supporting different ways of initialization, we need to support different path.
e.g. we have zksync_os, where we will be able to pass custom
contracts_path.For docker based deployment we will be able to calculate custom path inside containers.
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.