fix: bump foundry-zksync #4470
Merged
fix: bump foundry-zksync #4470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelemeno
requested review from
alexandrst88,
artmakh,
hatemosphere,
iluwaa,
onyxet and
yorik
Deniallugo
approved these changes
Sep 9, 2025
iluwaa
approved these changes
Sep 9, 2025
mm-zk-admin
pushed a commit
that referenced
this pull request
Sep 9, 2025
This reverts commit ec900cc. Bumping of foundry has caused a different bytecode hashes to be producted, which results a failures in genesis (mismatch hashes) and issues with unittests (hashes not matching era-contract ones). Rolling back for now, until we can find a better solution.
Deniallugo
pushed a commit
that referenced
this pull request
Oct 22, 2025
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Deniallugo
pushed a commit
that referenced
this pull request
Oct 22, 2025
This reverts commit ec900cc. Bumping of foundry has caused a different bytecode hashes to be producted, which results a failures in genesis (mismatch hashes) and issues with unittests (hashes not matching era-contract ones). Rolling back for now, until we can find a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.