fix(en): allow to disable sanity checks for commitment generation #4487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
reviewed
Sep 15, 2025
Deniallugo
force-pushed
the
deniallugo-disable-sanity-checks-for-en
branch
2 times, most recently
from
8be1abc to
06dd12e
Compare
Signed-off-by: Danil <[email protected]>
Deniallugo
force-pushed
the
deniallugo-disable-sanity-checks-for-en
branch
from
06dd12e to
e188f24
Compare
perekopskiy
approved these changes
Sep 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
🤖 I have created a release *beep* *boop* --- ## [29.3.0](core-v29.2.0...core-v29.3.0) (2025-09-18) ### Features * **en:** Check commitment allonside with roothashes ([#4492](#4492)) ([6e8f526](6e8f526)) * **en:** Improved en commitment generation error handling ([#4483](#4483)) ([1bb82d6](1bb82d6)) ### Bug Fixes * **en:** Add check for commitment in diverged batch ([#4493](#4493)) ([e693fd0](e693fd0)) * **en:** allow to disable sanity checks for commitment generation ([#4487](#4487)) ([7692f31](7692f31)) * **EN:** properly set chain_id for old batch transactions ([#4488](#4488)) ([634b6dd](634b6dd)) * **eth-proof-manager:** don't fail component if proof was incorrect ([#4444](#4444)) ([daa1161](daa1161)) * **eth-proof-manager:** verify protocol version and proving mode alignment ([#4473](#4473)) ([99e0423](99e0423)) * **eth-sender:** Fix selector for old batches ([#4489](#4489)) ([bb42dcf](bb42dcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Deniallugo
added a commit
that referenced
this pull request
Oct 22, 2025
) ## What ❔ Disabling sanity checks for commitment generation ## Why ❔ Our external node is designed around commitment generation and verification. Now it's possible to be in a situation, that we have incorrect block and we can't revert it, because we don't have a commitment for it. EN is not able to produce any commitment => EN can't verify the commitment => EN can't revert incorrect block. ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. Signed-off-by: Danil <[email protected]>
Deniallugo
pushed a commit
that referenced
this pull request
Oct 22, 2025
🤖 I have created a release *beep* *boop* --- ## [29.3.0](core-v29.2.0...core-v29.3.0) (2025-09-18) ### Features * **en:** Check commitment allonside with roothashes ([#4492](#4492)) ([6e8f526](6e8f526)) * **en:** Improved en commitment generation error handling ([#4483](#4483)) ([1bb82d6](1bb82d6)) ### Bug Fixes * **en:** Add check for commitment in diverged batch ([#4493](#4493)) ([e693fd0](e693fd0)) * **en:** allow to disable sanity checks for commitment generation ([#4487](#4487)) ([7692f31](7692f31)) * **EN:** properly set chain_id for old batch transactions ([#4488](#4488)) ([634b6dd](634b6dd)) * **eth-proof-manager:** don't fail component if proof was incorrect ([#4444](#4444)) ([daa1161](daa1161)) * **eth-proof-manager:** verify protocol version and proving mode alignment ([#4473](#4473)) ([99e0423](99e0423)) * **eth-sender:** Fix selector for old batches ([#4489](#4489)) ([bb42dcf](bb42dcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Disabling sanity checks for commitment generation
Why ❔
Our external node is designed around commitment generation and verification. Now it's possible to be in a situation, that we have incorrect block and we can't revert it, because we don't have a commitment for it.
EN is not able to produce any commitment => EN can't verify the commitment => EN can't revert incorrect block.
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.