fix: only apply EN seal criteria checks on >=v29 protocol #4491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
previously approved these changes
Sep 17, 2025
Deniallugo
previously approved these changes
Sep 18, 2025
Deniallugo
approved these changes
Sep 18, 2025
Deniallugo
pushed a commit
that referenced
this pull request
Oct 22, 2025
## What ❔ Only apply seal criteria checks through PanicSealer on >=v29 protocol ## Why ❔ Some older protocol versions had higher circuit (and maybe other) limits that are no longer avilable in code constants ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Only apply seal criteria checks through PanicSealer on >=v29 protocol
Why ❔
Some older protocol versions had higher circuit (and maybe other) limits that are no longer avilable in code constants
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.