-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: kl/medium-interop CI fixes #4516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
0xValera
wants to merge
155
commits into
draft-v31
Choose a base branch
from
vg/medium-interop-support-fixes
base: draft-v31
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,124
−378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto kl/medium-interop-support
…hub.com/matter-labs/zksync-era into kl/medium-interop-support
…hub.com/matter-labs/zksync-era into kl/medium-interop-support
…hub.com/matter-labs/zksync-era into kl/medium-interop-support
…hub.com/matter-labs/zksync-era into kl/medium-interop-support
This reverts commit 95bc6e8.
…in-vt-v29' into sma/change-memory-layout
…in-vt-v29' into sma/change-memory-layout
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
…posal-addresses-in-vt-v29
…abs/zksync-era into kl/medium-interop-support
…l/medium-interop-support
- Added support for `VmMediumInterop` in `get_max_vm_pubdata_per_batch`. - Updated `interop.sh` to include a command for creating a transaction filterer. - Refactored imports in `input.rs` and `output.rs` to streamline the use of `ZkStackConfigTrait`. - Adjusted path handling in `migrate_token_balances.rs` for better script management.
…l/medium-interop-support
…sync-era into kl/gw-asset-tracker-support
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Signed-off-by: Danil <[email protected]>
…nc-era into kl/gw-asset-tracker-support
- Commented out several lines in `interop.sh` related to the validium chain setup for clarity and future reference. - Updated the subproject commit reference in the contracts directory to the latest version.
fix: Kl/gw asset tracker support
…tests test: add 7930 support to interop test suite
…um-interop-support
…nto kl/medium-interop-support
…abs/zksync-era into kl/medium-interop-support
…CHAIN_ID variables; update subproject commit reference.
## What ❔ Temporarily bumps foundry-zksync version to [v0.0.26](https://github.com/matter-labs/foundry-zksync/releases/tag/foundry-zksync-v0.0.26) for [CI integration tests](https://github.com/matter-labs/zksync-era/blob/2842d753a3d7f8b056fc3293bbfbcb46a758ab6f/.github/workflows/ci-core-reusable.yml#L144-L145). This temporary fix is needed as CI uses the docker image built from the last run in main. Once merged to main (alongside draft-v30), it should be reverted via bumping the foundry-zksync version in the respective Docker containers, as done in this commit: e05f844. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
…into vg/medium-interop-support-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.