Skip to content

Conversation

@0xValera
Copy link
Contributor

@0xValera 0xValera commented Oct 3, 2025

What ❔

Why ❔

Is this a breaking change?

  • Yes
  • No

Operational changes

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.


There are three types of asset trackers:

- `L1AssetTracker`. It took over the job of tracking chain balances on L1, that was previosuly held by `L1NativeTokenVault`. Note that due to costs, it does not support interop.
Copy link
Contributor Author

@0xValera 0xValera Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about when we'll have L1 interop support (v31?)?

Copy link
Contributor

@StanislavBreadless StanislavBreadless Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlikely in v31, since the same reasoning about costs applies. Most likely it will require full ZK-based asset tracker for L1 support

Copy link
Contributor Author

@0xValera 0xValera Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that not a blocker for stage 1? If we're not able to "catch" an in-flight interop transfer started on L2-A on L1

Copy link
Contributor

@StanislavBreadless StanislavBreadless Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Receiving interop may indeed be a blocker for stage1, but it will not be supported in v30 anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v30 true, but in v31 we planned to have stage1, so that's why I brought it up initially


However, for migration-related messages for the ease of implementation we used the `migrationNumber` and `assetMigrationNumber`: An asset-migrating message can be only processed on L1 once, since to process it, the carried `migrationNumber` needs to be greater than the current `assetMigrationNumber`.

TODO: the current system allows for some of the old token withdrawals to never get finalized, this is bad, we'll have to rework it.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to rework it

OOS of v30? They will be finalizeable once we fix, but until then some of the old token withdrawals might be infinitely stuck?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be inside v30 IMO

@StanislavBreadless StanislavBreadless marked this pull request as ready for review October 7, 2025 16:42
@StanislavBreadless StanislavBreadless merged commit 69bb20b into kl/interop-docs Oct 7, 2025
15 of 17 checks passed
@StanislavBreadless StanislavBreadless deleted the sb/extend-auditor-docs branch October 7, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants