-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: sb/extend auditor docs on AssetTracker component #4522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| There are three types of asset trackers: | ||
|
|
||
| - `L1AssetTracker`. It took over the job of tracking chain balances on L1, that was previosuly held by `L1NativeTokenVault`. Note that due to costs, it does not support interop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about when we'll have L1 interop support (v31?)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlikely in v31, since the same reasoning about costs applies. Most likely it will require full ZK-based asset tracker for L1 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that not a blocker for stage 1? If we're not able to "catch" an in-flight interop transfer started on L2-A on L1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Receiving interop may indeed be a blocker for stage1, but it will not be supported in v30 anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v30 true, but in v31 we planned to have stage1, so that's why I brought it up initially
docs/src/specs/contracts/bridging/asset_tracker/asset_tracker.md
Outdated
Show resolved
Hide resolved
docs/src/specs/contracts/bridging/asset_tracker/asset_tracker.md
Outdated
Show resolved
Hide resolved
docs/src/specs/contracts/bridging/asset_tracker/asset_tracker.md
Outdated
Show resolved
Hide resolved
docs/src/specs/contracts/bridging/asset_tracker/asset_tracker.md
Outdated
Show resolved
Hide resolved
docs/src/specs/contracts/bridging/asset_tracker/asset_tracker.md
Outdated
Show resolved
Hide resolved
|
|
||
| However, for migration-related messages for the ease of implementation we used the `migrationNumber` and `assetMigrationNumber`: An asset-migrating message can be only processed on L1 once, since to process it, the carried `migrationNumber` needs to be greater than the current `assetMigrationNumber`. | ||
|
|
||
| TODO: the current system allows for some of the old token withdrawals to never get finalized, this is bad, we'll have to rework it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll have to rework it
OOS of v30? They will be finalizeable once we fix, but until then some of the old token withdrawals might be infinitely stuck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be inside v30 IMO
docs/src/specs/contracts/bridging/asset_tracker/asset_tracker.md
Outdated
Show resolved
Hide resolved
Co-authored-by: 0xValera <[email protected]>
…extend-auditor-docs
What ❔
Why ❔
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.