-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Improve proving networks setup #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilLuta
previously approved these changes
Oct 29, 2025
EmilLuta
approved these changes
Oct 30, 2025
This was referenced Oct 27, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
🤖 I have created a release *beep* *boop* --- ## [29.6.0](core-v29.5.0...core-v29.6.0) (2025-11-17) ### Features * **api:** add EIP-7966 eth_sendRawTransactionSync method ([#4565](#4565)) ([7c4c428](7c4c428)) * bumping versions ([#4555](#4555)) ([1cd803d](1cd803d)) * **eth_sender:** Set fusaka upgrade timestamp ([#4571](#4571)) ([3b5a9df](3b5a9df)) * Improve proving networks setup ([#4563](#4563)) ([42c3f0f](42c3f0f)) * **zkstack:** ensure priority queue is empty before migrating to gateway ([#4539](#4539)) ([a5e1133](a5e1133)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Deniallugo
pushed a commit
that referenced
this pull request
Dec 17, 2025
🤖 I have created a release *beep* *boop* --- ## [29.6.0](core-v29.5.0...core-v29.6.0) (2025-11-17) ### Features * **api:** add EIP-7966 eth_sendRawTransactionSync method ([#4565](#4565)) ([7c4c428](7c4c428)) * bumping versions ([#4555](#4555)) ([1cd803d](1cd803d)) * **eth_sender:** Set fusaka upgrade timestamp ([#4571](#4571)) ([3b5a9df](3b5a9df)) * Improve proving networks setup ([#4563](#4563)) ([42c3f0f](42c3f0f)) * **zkstack:** ensure priority queue is empty before migrating to gateway ([#4539](#4539)) ([a5e1133](a5e1133)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
🤖 I have created a release *beep* *boop* --- ## [23.2.0](prover-v23.1.0...prover-v23.2.0) (2025-12-17) ### Features * **crypto:** Update crypto deps ([#4587](#4587)) ([c5e7152](c5e7152)) * Improve proving networks setup ([#4563](#4563)) ([42c3f0f](42c3f0f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
attemptscolumn for submitting validation results. Initially the setup worked the way that validation results are being sent with retries, but without any measuring of attempts - so they are being sent until accepted. In some cases it gets the system stuck - like change of contracts or some other issues. So this PR addsattemptsand metrics for reached max attempts(configurable) - for which we can configure alert and react.proven_batchesandacknowledged_batcheswere reworked, so they emit the latest proven/acknowledged batch instead of total amount.failed_to_send_txsmetric was removed in favor ofreached_max_attemptsmetric.submitter_address- to track the address of the submitter in Grafana, for easier accesibilitysubmitter_balance- to track/set alerts on balance of submittercontract_address- address of proof manager contract - to be able to track the contract's state from GrafanaWhy ❔
This PR improves a few things in proving networks setup as preparation to going in production.
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.