feat: split gw ctm deployer #4615
Merged
+213
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
approved these changes
Jan 19, 2026
StanislavBreadless
changed the title
Deniallugo
reviewed
Jan 21, 2026
| .await?; | ||
|
|
||
| let l1_da_validator_addr = get_l1_da_validator(&chain_config) | ||
| let l1_da_validator_addr = get_l1_da_validator(&chain_config, args.validium_type.clone()) |
Contributor
There was a problem hiding this comment.
it can be discoverable.
let's refactor the script as the next step
Deniallugo
reviewed
Jan 21, 2026
zkstack_cli/crates/zkstack/src/commands/chain/gateway/migrate_to_gateway.rs
Outdated
Show resolved
Hide resolved
| L1BatchCommitmentMode::Validium => { | ||
| let general_config = chain_config.get_general_config().await?; | ||
| match general_config.da_client_type().as_deref() { | ||
| // Use CLI param if provided, otherwise read from general config |
Contributor
There was a problem hiding this comment.
You don't need to convert to string, for converting it to contracts
Contributor
Author
There was a problem hiding this comment.
Hmm, I'll still need to match by string for the sake of chain_config.get_general_config().await?.da_client_type() working, I can only reduce code repetition by giving some common method to convert ValidiumTypeInternal to a string
| } | ||
| } else { | ||
| let da_client_type = chain_config.get_general_config().await?.da_client_type(); | ||
| // For Validium, use CLI param if provided, otherwise read from general config |
Contributor
There was a problem hiding this comment.
You don't need to convert to string, for converting it to contracts
Deniallugo
approved these changes
Jan 23, 2026
Contributor
Author
|
CI is not worse than before, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
For the purposes of zksync os integration, we had to split GatewayCTMDeployer into multiple contracts.
Also, we had to adapt some of the scripts to work fine with the latest zksync os workflows
Why ❔
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.