feat: add support for Base Token Holder contract in server#4630
Open
feat: add support for Base Token Holder contract in server#4630
Conversation
Raid5594
commented
Jan 28, 2026
etc/env/file_based/genesis.yaml
Outdated
| @@ -1,5 +1,17 @@ | |||
| genesis_protocol_semantic_version: 0.31.0 | |||
Contributor
Author
There was a problem hiding this comment.
This file might be irrelevant to PR
kelemeno
reviewed
Jan 28, 2026
core/lib/types/src/storage/mod.rs
Outdated
| /// The initial balance of the BaseTokenHolder contract (2^127 - 1). | ||
| /// This value is used in L2BaseToken.totalSupply() calculation: | ||
| /// totalSupply = INITIAL_BASE_TOKEN_HOLDER_BALANCE - balance[BASE_TOKEN_HOLDER_ADDRESS] | ||
| pub const INITIAL_BASE_TOKEN_HOLDER_BALANCE: U256 = U256([ |
Contributor
There was a problem hiding this comment.
can't you set this in the genesis upgrade? but it might be ok
Contributor
Author
There was a problem hiding this comment.
Yes, we could set it during genesis upgrade, but I don't think there will be any practical difference.
kelemeno
reviewed
Jan 28, 2026
etc/env/file_based/genesis.yaml
Outdated
| genesis_protocol_version: null | ||
| genesis_root: 0x9470ae067ffd2b8661281c0d7d5a6f57697a1d32cd352f41efea06c696c4136a | ||
| genesis_rollup_leaf_index: 107 | ||
| genesis_batch_commitment: 0x19df9a1ed1b5ddf93f41c38be7cfca4ab35aba92ba926ec7b03a8e3422729b64 |
Contributor
There was a problem hiding this comment.
these were removed, you need to run zkstackup --local probably and do regensis. Changes should be minimal here
kelemeno
reviewed
Jan 28, 2026
| } | ||
| self.0.insert( | ||
| "prover.recursion_scheduler_level_vk_hash", | ||
| "prover.snark_wrapper_vk_hash", |
Contributor
There was a problem hiding this comment.
why is this change needed?
Contributor
Author
There was a problem hiding this comment.
#[derive(Debug, Clone, Default, Eq, PartialEq, Serialize, Deserialize)]
pub struct L1VerifierConfig {
// Rename is required to not introduce breaking changes in the API for existing clients.
#[serde(
alias = "recursion_scheduler_level_vk_hash",
rename(serialize = "recursion_scheduler_level_vk_hash")
)]
pub snark_wrapper_vk_hash: String,
pub fflonk_snark_wrapper_vk_hash: Option,
}
It is using aliasing for reading, so we'll just write the renamed version straightaway
Raid5594
force-pushed
the
ra/base-token-holder
branch
from
a037fb3 to
e1c38c7
Compare
Raid5594
force-pushed
the
ra/base-token-holder
branch
from
e1c38c7 to
4ed1fd0
Compare
This reverts commit e55d6b1.
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
## What ❔ matter-labs/era-contracts#2019 <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
## What ❔ Uses contracts from matter-labs/era-contracts#1993. They add additional protections for chains migrating to and from gateway as well as during withdrawal verification. No new server functionality should be required. ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
kelemeno
requested review from
alexandrst88,
artmakh,
hatemosphere,
iluwaa,
onyxet and
yorik
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Add support for Base Token Holder contract in server.
Why ❔
Base tokens have to be minted to the contract at genesis.
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmtandzkstack dev lint.