Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/ci-core-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4
with:
node-version: 18.20.8
node-version: 20

- name: Install yarn
run: |
Expand Down Expand Up @@ -187,6 +187,15 @@ jobs:
ci_run forge --version
ci_run rm -rf ./foundry-temp foundry_zksync_v0.1.5_linux_amd64.tar.gz

- name: (TEMPORARY) Update Node in ci_run container
run: |
ci_run bash -lc "curl -fsSL https://deb.nodesource.com/setup_20.x | bash -"
ci_run apt-get install -y nodejs
echo "Node version after update:"
ci_run node -v
ci_run npm -v
(ci_run yarn -v || ci_run npm install -g yarn) && ci_run yarn -v

- name: Build test dependencies
run: |
ci_run zkstack dev test build
Expand Down
2 changes: 1 addition & 1 deletion contracts
Submodule contracts updated 320 files
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,6 @@ export async function readAndBroadcastInteropBundle(
}

export async function readAndUnbundleInteropBundle(
sourceChainId: number,
wallet: zksync.Wallet,
senderProvider: zksync.Provider,
txHash: string
Expand All @@ -1011,7 +1010,7 @@ export async function readAndUnbundleInteropBundle(
await (await interopHandler.verifyBundle(data.rawData, data.proofDecoded)).wait();
// Unbundle the bundle, we will just set the call to `Executed`
const callStatuses = [CallStatus.Executed];
await (await interopHandler.unbundleBundle(sourceChainId, data.rawData, callStatuses)).wait();
await (await interopHandler.unbundleBundle(data.rawData, callStatuses)).wait();
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,6 @@ if (shouldSkip) {
for (const bundleName of Object.keys(bundlesUnbundledOnL1)) {
// We do not need to await the interop bundle as it was already executed on Gateway before we migrated back to L1.
await readAndUnbundleInteropBundle(
chainHandler.inner.chainId,
secondChainRichWallet,
chainRichWallet.provider,
bundlesUnbundledOnL1[bundleName].hash
Expand Down
15 changes: 6 additions & 9 deletions core/tests/ts-integration/tests/interop-b-unbundle.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ describe('Interop-B Unbundle behavior checks', () => {
bundles.fromSourceChain.data!.proofDecoded
]);
const unbundleBundleData = ctx.interop2InteropHandler.interface.encodeFunctionData('unbundleBundle', [
ctx.interop1ChainId,
bundles.fromSourceChain.data!.rawData,
finalCallStatuses
]);
Expand Down Expand Up @@ -211,7 +210,7 @@ describe('Interop-B Unbundle behavior checks', () => {
if (ctx.skipInteropTests) return;

await expect(
ctx.interop2InteropHandler.unbundleBundle(ctx.interop1ChainId, bundles.fromDestinationChain.data!.rawData, [
ctx.interop2InteropHandler.unbundleBundle(bundles.fromDestinationChain.data!.rawData, [
CallStatus.Executed,
CallStatus.Cancelled,
CallStatus.Executed
Expand Down Expand Up @@ -247,7 +246,7 @@ describe('Interop-B Unbundle behavior checks', () => {
ctx.interop2Recipient
);
await expect(
altInterop2InteropHandler.unbundleBundle(ctx.interop1ChainId, bundles.fromDestinationChain.data!.rawData, [
altInterop2InteropHandler.unbundleBundle(bundles.fromDestinationChain.data!.rawData, [
CallStatus.Executed,
CallStatus.Unprocessed,
CallStatus.Executed
Expand All @@ -258,7 +257,7 @@ describe('Interop-B Unbundle behavior checks', () => {
test('Cannot unbundle a failing call', async () => {
if (ctx.skipInteropTests) return;
await expect(
ctx.interop2InteropHandler.unbundleBundle(ctx.interop1ChainId, bundles.fromDestinationChain.data!.rawData, [
ctx.interop2InteropHandler.unbundleBundle(bundles.fromDestinationChain.data!.rawData, [
CallStatus.Unprocessed,
CallStatus.Executed,
CallStatus.Unprocessed
Expand All @@ -274,7 +273,6 @@ describe('Interop-B Unbundle behavior checks', () => {
// Leave call 0 as unprocessed (base token transfer), cancel call 1, and execute call 2 (token transfer)
const firstCallStatuses = [CallStatus.Unprocessed, CallStatus.Cancelled, CallStatus.Executed];
const firstUnbundleReceipt = await ctx.interop2InteropHandler.unbundleBundle(
ctx.interop1ChainId,
bundles.fromDestinationChain.data!.rawData,
firstCallStatuses
);
Expand All @@ -298,7 +296,6 @@ describe('Interop-B Unbundle behavior checks', () => {
// Unbundle again and process call 0 (base token transfer)
const balanceBefore = await ctx.getInterop2Balance(ctx.dummyInteropRecipient);
const secondUnbundleReceipt = await ctx.interop2InteropHandler.unbundleBundle(
ctx.interop1ChainId,
bundles.fromDestinationChain.data!.rawData,
[CallStatus.Executed, CallStatus.Unprocessed, CallStatus.Unprocessed]
);
Expand All @@ -321,7 +318,7 @@ describe('Interop-B Unbundle behavior checks', () => {
test('Cannot unbundle a processed call', async () => {
if (ctx.skipInteropTests) return;
await expect(
ctx.interop2InteropHandler.unbundleBundle(ctx.interop1ChainId, bundles.fromDestinationChain.data!.rawData, [
ctx.interop2InteropHandler.unbundleBundle(bundles.fromDestinationChain.data!.rawData, [
CallStatus.Executed,
CallStatus.Cancelled,
CallStatus.Executed
Expand All @@ -332,7 +329,7 @@ describe('Interop-B Unbundle behavior checks', () => {
test('Cannot unbundle a cancelled call', async () => {
if (ctx.skipInteropTests) return;
await expect(
ctx.interop2InteropHandler.unbundleBundle(ctx.interop1ChainId, bundles.fromDestinationChain.data!.rawData, [
ctx.interop2InteropHandler.unbundleBundle(bundles.fromDestinationChain.data!.rawData, [
CallStatus.Unprocessed,
CallStatus.Executed,
CallStatus.Unprocessed
Expand All @@ -343,7 +340,7 @@ describe('Interop-B Unbundle behavior checks', () => {
test('Cannot cancel a processed call', async () => {
if (ctx.skipInteropTests) return;
await expect(
ctx.interop2InteropHandler.unbundleBundle(ctx.interop1ChainId, bundles.fromDestinationChain.data!.rawData, [
ctx.interop2InteropHandler.unbundleBundle(bundles.fromDestinationChain.data!.rawData, [
CallStatus.Cancelled,
CallStatus.Cancelled,
CallStatus.Cancelled
Expand Down
Loading