Conversation
ci-run-tests LCOV of commit
|
|
@vasyl-ivanchuk resolved the CI issues. Re: the "getTransactionCount ('latest' for deposits, 'pending' for withdrawals)" This is non-intentional and likely an oversight on my part. It should be updated to rely entirely on |
@dutterbutter as far as I see, NonceManager uses pending BlockTag to get the nonce and doesn't provide any interface to change it. There might be use cases where using the latest nonce is preferable. For instance, to override a transaction in the mempool. Watchdog uses latest for this exact reason. |
What 💻
Add optional
noncefield toTxOverridesto give callers control over nonce resolution in deposits and withdrawals. Whennonceis anumber, it's used as the starting nonce directly (skippinggetTransactionCount). Whennonceis'latest'or'pending',getTransactionCountis called with that block tag, allowing callers to choose between confirmed vs pending nonce.Why ✋
The SDK currently hardcodes the block tag used for
getTransactionCount('latest'for deposits,'pending'for withdrawals) and provides no way to supply a known nonce. This is limiting for integrators who need to control whether the nonce accounts for pending transactions or only confirmed ones. For example: watchdog project intentionally useslatestnonce for withdrawals.