Skip to content

feat: export extractL2TxHashFromL1Logs#62

Merged
dutterbutter merged 4 commits intomainfrom
vi/export-extract-l2txhash-fn
Feb 17, 2026
Merged

feat: export extractL2TxHashFromL1Logs#62
dutterbutter merged 4 commits intomainfrom
vi/export-extract-l2txhash-fn

Conversation

@vasyl-ivanchuk
Copy link
Contributor

What 💻

Export extractL2TxHashFromL1Logs from the SDK.

Why ✋

It makes sense to export this alongside other utils functions. The old SDK exports a similar function used by projects like Watchdog. Exporting it here makes the migration to the new SDK easier.

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

ci-run-tests LCOV of commit 0cf754c during ci-run-tests #187

Summary coverage rate:
  lines......: 83.9% (13390 of 15953 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                              |Lines       |Functions  |Branches    
  Filename                                                                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================================================================
  src/adapters/ethers/resources/deposits/index.ts                             | 0.0%    178|    -     0|    -      0
  src/adapters/ethers/resources/deposits/services/verification.ts             | 0.0%     62|    -     0|    -      0
  src/adapters/ethers/resources/interop/resolvers.ts                          | 0.0%     10|    -     0|    -      0
  src/adapters/viem/resources/deposits/index.ts                               | 0.0%    221|    -     0|    -      0
  src/adapters/viem/resources/deposits/services/verification.ts               | 0.0%     53|    -     0|    -      0

Full coverage report

@dutterbutter
Copy link
Contributor

dutterbutter commented Feb 17, 2026

Totally agree with this but may I request a rename since we are exporting to a more user friendly name. My suggestion getL2TransactionHashFromLogs. Thoughts?

@dutterbutter dutterbutter merged commit 508d4c9 into main Feb 17, 2026
16 checks passed
@dutterbutter dutterbutter deleted the vi/export-extract-l2txhash-fn branch February 17, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants