feat: add BatchIndex and more metrics for ObjectStore [ON HOLD]#495
Open
dimazhornyk wants to merge 5 commits intomainfrom
Open
feat: add BatchIndex and more metrics for ObjectStore [ON HOLD]#495dimazhornyk wants to merge 5 commits intomainfrom
dimazhornyk wants to merge 5 commits intomainfrom
Conversation
Test results112 tests 112 ✅ 18m 40s ⏱️ Results for commit e0e0e90. ♻️ This comment has been updated with latest results. |
dimazhornyk
changed the title
Collaborator
|
@dimazhornyk thanks a lot for your contibution! This is currently on-hold as we are addressing this. Plan to tackle it later this week. This PR will used in some form - I'll reach out if I need any advice! |
RomanBrodetski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds the
block_number->batch_numberandbatch_number->(first_block, last_block)indexes that help reduce the amount of S3 reads and significantly lower the network load.#205 #454 (adds read/write counter and total amount of downloaded data)