test: Add P256 integration tests with REVM consistency checker#797
Open
vladbochok wants to merge 2 commits intomainfrom
Open
test: Add P256 integration tests with REVM consistency checker#797vladbochok wants to merge 2 commits intomainfrom
vladbochok wants to merge 2 commits intomainfrom
Conversation
Test results185 tests 185 ✅ 17m 31s ⏱️ Results for commit e428a1f. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have found a bug in zksync-os-revm, that leads to incorrect gas calculations in P256 precompile. To avoid inconsistency in the future:
Impact on CI
The change slow down the integration tests pipeline, by local benchmarks from 213s to 286s:
Before:
After:
Relevant PRs
PR with a fix in
zksync-os-revm: