feat: use max_priority_fee_per_gas as cap in base token adjuster#858
Open
RomanBrodetski wants to merge 1 commit intomainfrom
Open
feat: use max_priority_fee_per_gas as cap in base token adjuster#858RomanBrodetski wants to merge 1 commit intomainfrom
RomanBrodetski wants to merge 1 commit intomainfrom
Conversation
Change base token adjuster to use max_priority_fee_per_gas and max_fee_per_gas as actual caps rather than fixed values. Now uses min(estimated, configured) for both fees: - When network fee is lower than config, use the lower network fee (saves money) - When network fee is higher than config, cap at config value (respects limits) Improved warning messages to explain when fees are capped and clarify the context (for base token price adjustment). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Test results186 tests 186 ✅ 18m 14s ⏱️ Results for commit 23a8d1b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change base token adjuster to use max_priority_fee_per_gas and max_fee_per_gas as actual caps rather than fixed values.
This is consistent with changes here.